Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 2815343002: Enable networking.onc for stable channel (Closed)

Created:
3 years, 8 months ago by tbarzic
Modified:
3 years, 8 months ago
Reviewers:
stevenjb, Devlin
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable networking.onc for stable channel Restricts methods for activating sim/setting sim lock to private users (primarily used by web ui). BUG=711336 Review-Url: https://codereview.chromium.org/2815343002 Cr-Commit-Position: refs/heads/master@{#464567} Committed: https://chromium.googlesource.com/chromium/src/+/d7b3785d27b8827f3c1e01342c4882827b83661f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -1 line) Patch
M extensions/browser/api/networking_private/networking_private_api.cc View 3 chunks +15 lines, -0 lines 0 comments Download
M extensions/common/api/_permission_features.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
tbarzic
3 years, 8 months ago (2017-04-13 17:41:10 UTC) #6
stevenjb
lgtm
3 years, 8 months ago (2017-04-13 17:41:47 UTC) #7
Devlin
lgtm
3 years, 8 months ago (2017-04-13 21:42:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2815343002/1
3 years, 8 months ago (2017-04-13 21:48:39 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-13 22:18:26 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d7b3785d27b8827f3c1e01342c48...

Powered by Google App Engine
This is Rietveld 408576698