Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Unified Diff: extensions/browser/api/networking_private/networking_private_api.cc

Issue 2815343002: Enable networking.onc for stable channel (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | extensions/common/api/_permission_features.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/api/networking_private/networking_private_api.cc
diff --git a/extensions/browser/api/networking_private/networking_private_api.cc b/extensions/browser/api/networking_private/networking_private_api.cc
index d887a397311eabb6f3ff3af9b574eb218e557a8b..33015b240e80245cb2b718248d629bf5d7a449f6 100644
--- a/extensions/browser/api/networking_private/networking_private_api.cc
+++ b/extensions/browser/api/networking_private/networking_private_api.cc
@@ -643,6 +643,11 @@ NetworkingPrivateStartActivateFunction::
ExtensionFunction::ResponseAction
NetworkingPrivateStartActivateFunction::Run() {
+ if (!HasPrivateNetworkingAccess(extension(), source_context_type(),
+ source_url())) {
+ return RespondNow(Error(kPrivateOnlyError));
+ }
+
std::unique_ptr<private_api::StartActivate::Params> params =
private_api::StartActivate::Params::Create(*args_);
EXTENSION_FUNCTION_VALIDATE(params);
@@ -945,6 +950,11 @@ NetworkingPrivateUnlockCellularSimFunction::
ExtensionFunction::ResponseAction
NetworkingPrivateUnlockCellularSimFunction::Run() {
+ if (!HasPrivateNetworkingAccess(extension(), source_context_type(),
+ source_url())) {
+ return RespondNow(Error(kPrivateOnlyError));
+ }
+
std::unique_ptr<private_api::UnlockCellularSim::Params> params =
private_api::UnlockCellularSim::Params::Create(*args_);
EXTENSION_FUNCTION_VALIDATE(params);
@@ -979,6 +989,11 @@ NetworkingPrivateSetCellularSimStateFunction::
ExtensionFunction::ResponseAction
NetworkingPrivateSetCellularSimStateFunction::Run() {
+ if (!HasPrivateNetworkingAccess(extension(), source_context_type(),
+ source_url())) {
+ return RespondNow(Error(kPrivateOnlyError));
+ }
+
std::unique_ptr<private_api::SetCellularSimState::Params> params =
private_api::SetCellularSimState::Params::Create(*args_);
EXTENSION_FUNCTION_VALIDATE(params);
« no previous file with comments | « no previous file | extensions/common/api/_permission_features.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698