Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(686)

Unified Diff: media/formats/mp4/dolby_vision.cc

Issue 2815303006: Convert MediaLog from being ref counted to owned by WebMediaPlayer. (Closed)
Patch Set: Actually fix fuzzers. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/formats/mp4/dolby_vision.cc
diff --git a/media/formats/mp4/dolby_vision.cc b/media/formats/mp4/dolby_vision.cc
index c40decdf28276deb3830a4c5fe4a49d0a0b7fad1..743fa9e38b9e230d527dd0fd10a40cf8a7210d0b 100644
--- a/media/formats/mp4/dolby_vision.cc
+++ b/media/formats/mp4/dolby_vision.cc
@@ -34,12 +34,13 @@ bool DolbyVisionConfiguration::Parse(BoxReader* reader) {
bool DolbyVisionConfiguration::Parse(const uint8_t* data, int data_size) {
BufferReader reader(data, data_size);
- return ParseInternal(&reader, new MediaLog());
+ // TODO(wolenetz): Questionable MediaLog usage, http://crbug.com/712310
chcunningham 2017/04/18 23:29:12 This one should be easy to fix. We have the media
DaleCurtis 2017/04/18 23:55:45 Looking closer I think this is only used by the un
+ MediaLog media_log;
+ return ParseInternal(&reader, &media_log);
}
-bool DolbyVisionConfiguration::ParseInternal(
- BufferReader* reader,
- const scoped_refptr<MediaLog>& media_log) {
+bool DolbyVisionConfiguration::ParseInternal(BufferReader* reader,
+ MediaLog* media_log) {
uint16_t profile_track_indication = 0;
RCHECK(reader->Read1(&dv_version_major) && reader->Read1(&dv_version_minor) &&
reader->Read2(&profile_track_indication));

Powered by Google App Engine
This is Rietveld 408576698