Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(907)

Unified Diff: media/formats/mp4/hevc.cc

Issue 2815303006: Convert MediaLog from being ref counted to owned by WebMediaPlayer. (Closed)
Patch Set: Actually fix fuzzers. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/formats/mp4/hevc.cc
diff --git a/media/formats/mp4/hevc.cc b/media/formats/mp4/hevc.cc
index de8fe962e3c27774ac3b468801e15ee079914a41..c0224abac22c35fe470ca0a5a930f539685a63d2 100644
--- a/media/formats/mp4/hevc.cc
+++ b/media/formats/mp4/hevc.cc
@@ -48,7 +48,9 @@ bool HEVCDecoderConfigurationRecord::Parse(BoxReader* reader) {
bool HEVCDecoderConfigurationRecord::Parse(const uint8_t* data, int data_size) {
BufferReader reader(data, data_size);
- return ParseInternal(&reader, new MediaLog());
+ // TODO(wolenetz): Questionable MediaLog usage, http://crbug.com/712310
+ MediaLog media_log;
+ return ParseInternal(&reader, &media_log);
chcunningham 2017/04/18 23:29:12 same story - should be easy to fix this one
DaleCurtis 2017/04/18 23:55:46 This one's actually used by https://cs.chromium.or
}
HEVCDecoderConfigurationRecord::HVCCNALArray::HVCCNALArray()
@@ -59,9 +61,8 @@ HEVCDecoderConfigurationRecord::HVCCNALArray::HVCCNALArray(
HEVCDecoderConfigurationRecord::HVCCNALArray::~HVCCNALArray() {}
-bool HEVCDecoderConfigurationRecord::ParseInternal(
- BufferReader* reader,
- const scoped_refptr<MediaLog>& media_log) {
+bool HEVCDecoderConfigurationRecord::ParseInternal(BufferReader* reader,
+ MediaLog* media_log) {
uint8_t profile_indication = 0;
uint32_t general_constraint_indicator_flags_hi = 0;
uint16_t general_constraint_indicator_flags_lo = 0;

Powered by Google App Engine
This is Rietveld 408576698