Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 2815303005: Avoid setting alpha mode for H264 webm containers (Closed)

Created:
3 years, 8 months ago by emircan
Modified:
3 years, 8 months ago
Reviewers:
mcasas
CC:
chromium-reviews, chfremer+watch_chromium.org, feature-media-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Avoid setting alpha mode for H264 webm containers BUG=711825 TEST=Tested MediaRecorder H264 playback on Android. Review-Url: https://codereview.chromium.org/2815303005 Cr-Commit-Position: refs/heads/master@{#464852} Committed: https://chromium.googlesource.com/chromium/src/+/097db1d2d5de77aec5c32c710bd90b7a481deb09

Patch Set 1 #

Total comments: 1

Patch Set 2 : mcasas@ nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M media/muxers/webm_muxer.cc View 1 2 chunks +7 lines, -4 lines 0 comments Download

Messages

Total messages: 17 (13 generated)
emircan
PTAL.
3 years, 8 months ago (2017-04-14 23:05:46 UTC) #5
mcasas
lgtm https://codereview.chromium.org/2815303005/diff/1/media/muxers/webm_muxer.cc File media/muxers/webm_muxer.cc (right): https://codereview.chromium.org/2815303005/diff/1/media/muxers/webm_muxer.cc#newcode253 media/muxers/webm_muxer.cc:253: // Set alpha channel parameters for only VPX, ...
3 years, 8 months ago (2017-04-14 23:34:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2815303005/20001
3 years, 8 months ago (2017-04-15 01:55:23 UTC) #14
commit-bot: I haz the power
3 years, 8 months ago (2017-04-15 02:49:34 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/097db1d2d5de77aec5c32c710bd9...

Powered by Google App Engine
This is Rietveld 408576698