Avoid setting alpha mode for H264 webm containers

Avoid setting alpha mode for H264 webm containers

BUG=711825
TEST=Tested MediaRecorder H264 playback on Android.

Review-Url: https://codereview.chromium.org/2815303005
Cr-Commit-Position: refs/heads/master@{#464852}
Committed: https://chromium.googlesource.com/chromium/src/+/097db1d2d5de77aec5c32c710bd90b7a481deb09

[emircan, 2017-04-14 23:04:16]

The CQ bit was checked by emircan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-14 23:04:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[emircan, 2017-04-14 23:05:38]

Description was changed from

==========
Avoid setting alpha mode for H264 webm containers

BUG=711825
==========

to

==========
Avoid setting alpha mode for H264 webm containers

BUG=711825
TEST=Tested MediaRecorder playback on Android.
==========

[emircan, 2017-04-14 23:05:38]

emircan@chromium.org changed reviewers:
+ mcasas@chromium.org

[emircan, 2017-04-14 23:05:46]

PTAL.

[emircan, 2017-04-14 23:06:10]

Description was changed from

==========
Avoid setting alpha mode for H264 webm containers

BUG=711825
TEST=Tested MediaRecorder playback on Android.
==========

to

==========
Avoid setting alpha mode for H264 webm containers

BUG=711825
TEST=Tested MediaRecorder H264 playback on Android.
==========

[mcasas, 2017-04-14 23:34:52]

lgtm

https://codereview.chromium.org/2815303005/diff/1/media/muxers/webm_muxer.cc
File media/muxers/webm_muxer.cc (right):

https://codereview.chromium.org/2815303005/diff/1/media/muxers/webm_muxer.cc#...
media/muxers/webm_muxer.cc:253: // Set alpha channel parameters for only VPX,
see crbug.com/711825.
nit: "only for VPx (https://crbug.com/711825)."

[emircan, 2017-04-14 23:45:18]

The CQ bit was checked by emircan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-14 23:45:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-15 01:41:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-15 01:41:26]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[emircan, 2017-04-15 01:55:09]

The CQ bit was checked by emircan@chromium.org

[emircan, 2017-04-15 01:55:10]

The patchset sent to the CQ was uploaded after l-g-t-m from mcasas@chromium.org
Link to the patchset: https://codereview.chromium.org/2815303005/#ps20001
(title: "mcasas@ nit")

[commit-bot: I haz the power, 2017-04-15 01:55:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-15 02:48:42]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492221309946200,
"parent_rev": "857ac08c0b81d529bae45a20584adeb4f98e653a", "commit_rev":
"097db1d2d5de77aec5c32c710bd90b7a481deb09"}

[commit-bot: I haz the power, 2017-04-15 02:49:33]

Description was changed from

==========
Avoid setting alpha mode for H264 webm containers

BUG=711825
TEST=Tested MediaRecorder H264 playback on Android.
==========

to

==========
Avoid setting alpha mode for H264 webm containers

BUG=711825
TEST=Tested MediaRecorder H264 playback on Android.

Review-Url: https://codereview.chromium.org/2815303005
Cr-Commit-Position: refs/heads/master@{#464852}
Committed:
https://chromium.googlesource.com/chromium/src/+/097db1d2d5de77aec5c32c710bd9...
==========

[commit-bot: I haz the power, 2017-04-15 02:49:34]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/097db1d2d5de77aec5c32c710bd9...