IPH - Added triggers to show Download Home message

IPH - Added triggers to show Download Home message

This CL shows in-product-help message to user about download home.
The text bubble would be shown at chrome startup if the user has completed at least one download.

Backend interaction:
1 - On every startup - Check ShouldTriggerHelpUI(IPH_DownloadHome)
2 - On every completed download - Send event download_completed
3 - On every open of download home - Send event download_home_opened
4 - On every dismiss of IPH - Send dismissed() to tracker

BUG=710647
Review-Url: https://codereview.chromium.org/2815183002
Cr-Commit-Position: refs/heads/master@{#467154}
Committed: https://chromium.googlesource.com/chromium/src/+/56bf32f77a418628dd04bc68f4ef8400a3cf0480

[shaktisahu, 2017-04-13 01:27:21]

Description was changed from

==========
IPH - Added triggers to show Download Home message

BUG=710647
==========

to

==========
IPH - Added triggers to show Download Home message

BUG=710647
==========

[shaktisahu, 2017-04-13 01:27:21]

shaktisahu@chromium.org changed reviewers:
+ dtrainor@chromium.org, nyquist@chromium.org

[shaktisahu, 2017-04-13 01:28:04]

PTAL
I haven't added the highlight menu stuff.

[David Trainor- moved to gerrit, 2017-04-13 07:34:04]

lgtm

[shaktisahu, 2017-04-14 04:45:55]

The CQ bit was checked by shaktisahu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-14 04:46:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-14 06:39:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-14 06:39:08]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[nyquist, 2017-04-18 23:21:22]

should we add an event for when chrome is opened? Preferrably something that
isn't just "native has loaded", but some incoming event that happens, just so
that if there are multiple "on start of Chrome" events, they can happen even if
Chrome has started once?

https://codereview.chromium.org/2815183002/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
(right):

https://codereview.chromium.org/2815183002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java:720:
Profile.getLastUsedProfile());
This call is delayed, are we sure this is for the correct profile?

https://codereview.chromium.org/2815183002/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java
(right):

https://codereview.chromium.org/2815183002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java:1333:
Profile.getLastUsedProfile());
Is this always the correct profile? Or could it be for a different tab?

[David Trainor- moved to gerrit, 2017-04-25 03:45:30]

Small suggestion for a future CL.  Still lgtm.

https://codereview.chromium.org/2815183002/diff/80001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
(right):

https://codereview.chromium.org/2815183002/diff/80001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java:728:
mHandler.post(new Runnable() {
If we're doing this often, maybe we should change this a bit and trigger the
onDismiss listener inside a post for all cases.

[shaktisahu, 2017-04-25 19:01:19]

Description was changed from

==========
IPH - Added triggers to show Download Home message

BUG=710647
==========

to

==========
IPH - Added triggers to show Download Home message

This CL shows in-product-help message to user about download home.
The text bubble would be shown at chrome startup if the user has completed at
least one download.

Backend interaction:
1 - On every startup - Check ShouldTriggerHelpUI(IPH_DownloadHome)
2 - On every completed download - Send event download_completed
3 - On every open of download home - Send event download_home_opened
4 - On every dismiss of IPH - Send dismissed() to tracker

BUG=710647
==========

[shaktisahu, 2017-04-25 19:22:15]

Patchset #6 (id:100001) has been deleted

[shaktisahu, 2017-04-25 19:22:42]

The CQ bit was checked by shaktisahu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-25 19:23:14]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[shaktisahu, 2017-04-25 20:57:39]

The CQ bit was checked by shaktisahu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-25 20:58:37]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[shaktisahu, 2017-04-25 21:47:25]

The CQ bit was checked by shaktisahu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-25 21:48:03]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-25 22:37:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-25 22:38:00]

Dry run: This issue passed the CQ dry run.

[shaktisahu, 2017-04-25 22:48:30]

The CQ bit was checked by shaktisahu@chromium.org

[shaktisahu, 2017-04-25 22:48:30]

The patchset sent to the CQ was uploaded after l-g-t-m from
dtrainor@chromium.org
Link to the patchset: https://codereview.chromium.org/2815183002/#ps160001
(title: "findbugs")

[commit-bot: I haz the power, 2017-04-25 22:49:08]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-25 22:54:15]

CQ is committing da patch.

Bot data: {"patchset_id": 160001, "attempt_start_ts": 1493160510593570,
"parent_rev": "2d81ffe246030878e383efdde6445f6ac35741f4", "commit_rev":
"56bf32f77a418628dd04bc68f4ef8400a3cf0480"}

[commit-bot: I haz the power, 2017-04-25 22:54:23]

Description was changed from

==========
IPH - Added triggers to show Download Home message

This CL shows in-product-help message to user about download home.
The text bubble would be shown at chrome startup if the user has completed at
least one download.

Backend interaction:
1 - On every startup - Check ShouldTriggerHelpUI(IPH_DownloadHome)
2 - On every completed download - Send event download_completed
3 - On every open of download home - Send event download_home_opened
4 - On every dismiss of IPH - Send dismissed() to tracker

BUG=710647
==========

to

==========
IPH - Added triggers to show Download Home message

This CL shows in-product-help message to user about download home.
The text bubble would be shown at chrome startup if the user has completed at
least one download.

Backend interaction:
1 - On every startup - Check ShouldTriggerHelpUI(IPH_DownloadHome)
2 - On every completed download - Send event download_completed
3 - On every open of download home - Send event download_home_opened
4 - On every dismiss of IPH - Send dismissed() to tracker

BUG=710647

Review-Url: https://codereview.chromium.org/2815183002
Cr-Commit-Position: refs/heads/master@{#467154}
Committed:
https://chromium.googlesource.com/chromium/src/+/56bf32f77a418628dd04bc68f4ef...
==========

[commit-bot: I haz the power, 2017-04-25 22:54:27]

Committed patchset #8 (id:160001) as
https://chromium.googlesource.com/chromium/src/+/56bf32f77a418628dd04bc68f4ef...