chrome/android/java/src/org/chromium/chrome/browser/download/SystemDownloadNotifier.java - Issue 2815183002: IPH - Added triggers to show Download Home message

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/download/SystemDownloadNotifier.java

Issue 2815183002: IPH - Added triggers to show Download Home message (Closed)

Patch Set: findbugs Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/download/DownloadUtils.java ('k') | chrome/android/java/strings/android_chrome_strings.grd » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/download/SystemDownloadNotifier.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/download/SystemDownloadNotifier.java b/chrome/android/java/src/org/chromium/chrome/browser/download/SystemDownloadNotifier.java

index 8612e0f71f5febb7c6e1307dbe62790c787074b7..1d6ad3aa57d5a19c5959a2d75806d444e23bb476 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/download/SystemDownloadNotifier.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/download/SystemDownloadNotifier.java

@@ -233,8 +233,8 @@ public class SystemDownloadNotifier implements DownloadNotifier, Observer {

@VisibleForTesting

void onSuccessNotificationShown(

final PendingNotificationInfo notificationInfo, final int notificationId) {

- if (notificationInfo.downloadInfo != null

- && !notificationInfo.downloadInfo.getIsOpenable()) {

+ if (notificationInfo.downloadInfo == null

+ || !notificationInfo.downloadInfo.getIsOpenable()) {

return;

}

DownloadManagerService.getDownloadManagerService().onSuccessNotificationShown(