[MD settings] limit scope of subpage animating attribute

[MD settings] limit scope of subpage animating attribute

This CL reduces the occurrances where isSubpageAnimating is used. We
primarily need this hack to fix an issue going between subpages, but we
had broadened it to all animations for good measure. There is an issue
transitioning from the a11y subpage to the appearance on the main page
that we don't yet have another solution for. Reducing the scope fixes
scrolling issue in bug 708465.

BUG=708465
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2815163003
Cr-Commit-Position: refs/heads/master@{#464500}
Committed: https://chromium.googlesource.com/chromium/src/+/70df80adfac5d24b6ade4507b919e05df88ab029

[dschuyler, 2017-04-13 00:03:54]

Description was changed from

==========
[MD settings] limit scope of subpage animating attribute

This CL reduces the occurrances where isSubpageAnimating is used. We
primarily need this hack to fix an issue going between subpages, but we
had broadened it to all animations for good measure. There is an issue
transitioning from the a11y subpage to the appearance on the main page
that we don't yet have another solution for. Reducing the scope fixes
scrolling issue in bug 708465.

BUG=708465
==========

to

==========
[MD settings] limit scope of subpage animating attribute

This CL reduces the occurrances where isSubpageAnimating is used. We
primarily need this hack to fix an issue going between subpages, but we
had broadened it to all animations for good measure. There is an issue
transitioning from the a11y subpage to the appearance on the main page
that we don't yet have another solution for. Reducing the scope fixes
scrolling issue in bug 708465.

BUG=708465
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dschuyler, 2017-04-13 00:03:56]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-13 00:05:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dschuyler, 2017-04-13 00:10:32]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[dschuyler, 2017-04-13 00:11:14]

dschuyler@chromium.org changed reviewers:
+ dbeam@chromium.org

[commit-bot: I haz the power, 2017-04-13 00:11:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dschuyler, 2017-04-13 00:12:18]

On 2017/04/13 00:11:15, dschuyler wrote:

This CL supersedes https://codereview.chromium.org/2812983004/

[Dan Beam, 2017-04-13 01:27:07]

lgtm

[commit-bot: I haz the power, 2017-04-13 01:52:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-13 01:52:27]

Dry run: This issue passed the CQ dry run.

[tommycli, 2017-04-13 17:08:39]

On 2017/04/13 01:27:07, Dan Beam wrote:
> lgtm

Nice fix!

[dschuyler, 2017-04-13 18:55:15]

The CQ bit was checked by dschuyler@chromium.org

[commit-bot: I haz the power, 2017-04-13 18:55:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 19:24:52]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492109715513150,
"parent_rev": "863b0d4dbe21b493e2dfa59c6d52e02a1af73565", "commit_rev":
"70df80adfac5d24b6ade4507b919e05df88ab029"}

[commit-bot: I haz the power, 2017-04-13 19:25:42]

Description was changed from

==========
[MD settings] limit scope of subpage animating attribute

This CL reduces the occurrances where isSubpageAnimating is used. We
primarily need this hack to fix an issue going between subpages, but we
had broadened it to all animations for good measure. There is an issue
transitioning from the a11y subpage to the appearance on the main page
that we don't yet have another solution for. Reducing the scope fixes
scrolling issue in bug 708465.

BUG=708465
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD settings] limit scope of subpage animating attribute

This CL reduces the occurrances where isSubpageAnimating is used. We
primarily need this hack to fix an issue going between subpages, but we
had broadened it to all animations for good measure. There is an issue
transitioning from the a11y subpage to the appearance on the main page
that we don't yet have another solution for. Reducing the scope fixes
scrolling issue in bug 708465.

BUG=708465
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2815163003
Cr-Commit-Position: refs/heads/master@{#464500}
Committed:
https://chromium.googlesource.com/chromium/src/+/70df80adfac5d24b6ade4507b919...
==========

[commit-bot: I haz the power, 2017-04-13 19:25:43]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/70df80adfac5d24b6ade4507b919...