Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2260)

Unified Diff: chrome/browser/resources/settings/settings_page/main_page_behavior.js

Issue 2815163003: [MD settings] limit scope of subpage animating attribute (Closed)
Patch Set: comment Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/settings_page/main_page_behavior.js
diff --git a/chrome/browser/resources/settings/settings_page/main_page_behavior.js b/chrome/browser/resources/settings/settings_page/main_page_behavior.js
index 6983546cefafa7429188c946682390539963ffc3..3886816a9110fcb731267fad86474ae00c3b1cf4 100644
--- a/chrome/browser/resources/settings/settings_page/main_page_behavior.js
+++ b/chrome/browser/resources/settings/settings_page/main_page_behavior.js
@@ -85,7 +85,11 @@ var MainPageBehaviorImpl = {
oldRouteWasSection || oldRoute == settings.Route.BASIC ||
oldRoute == settings.Route.ABOUT;
- if (oldRoute && (oldRoute.isSubpage() || newRoute.isSubpage()))
+ // TODO(dschuyler): This doesn't set the flag in the case of going to or
+ // from the main page. It seems sensible to set the flag in those cases,
+ // unfortunately bug 708465 happens. Figure out why that is and then set
+ // this flag more broadly.
+ if (oldRoute && oldRoute.isSubpage() && newRoute.isSubpage())
this.isSubpageAnimating = true;
// For previously uncreated pages (including on first load), allow the page
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698