Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 2815093006: Stop notification updates from unpausing toast timers. (Closed)

Created:
3 years, 8 months ago by yhanada
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Stop notification updates from unpausing toast timers. Notification toast timers are paused when the notification gains focus. If a notification is updated while it is paused, then previously, its timer would be unpaused. So, it would disappear while being focused. BUG=710298 Review-Url: https://codereview.chromium.org/2810723004 Cr-Commit-Position: refs/heads/master@{#463943} (cherry picked from commit c556f5a3a662c0b79ae7961f8bdbfaf2cc4236fb) Review-Url: https://codereview.chromium.org/2815093006 . Cr-Commit-Position: refs/branch-heads/3029@{#708} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/0f41f7a2f609c86c39fce1c92b1e4f0438e447ff

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M ui/message_center/popup_timer.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/message_center/popup_timers_controller.cc View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
yhanada
3 years, 8 months ago (2017-04-14 04:37:39 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0f41f7a2f609c86c39fce1c92b1e4f0438e447ff.

Powered by Google App Engine
This is Rietveld 408576698