Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Issue 2810723004: Stop notification updates from unpausing toast timers. (Closed)

Created:
3 years, 8 months ago by Eliot Courtney
Modified:
3 years, 8 months ago
Reviewers:
xiyuan, yoshiki
CC:
chromium-reviews, Peter Beverloo, mlamouri+watch-notifications_chromium.org, awdf+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Stop notification updates from unpausing toast timers. Notification toast timers are paused when the notification gains focus. If a notification is updated while it is paused, then previously, its timer would be unpaused. So, it would disappear while being focused. BUG=710298 Review-Url: https://codereview.chromium.org/2810723004 Cr-Commit-Position: refs/heads/master@{#463943} Committed: https://chromium.googlesource.com/chromium/src/+/c556f5a3a662c0b79ae7961f8bdbfaf2cc4236fb

Patch Set 1 #

Patch Set 2 : Fix comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M ui/message_center/popup_timer.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/message_center/popup_timers_controller.cc View 1 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Eliot Courtney
PTAL~! Thanks.
3 years, 8 months ago (2017-04-11 01:38:57 UTC) #4
yoshiki
lgtm Thanks!
3 years, 8 months ago (2017-04-11 01:49:30 UTC) #5
xiyuan
lgtm
3 years, 8 months ago (2017-04-11 15:31:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2810723004/20001
3 years, 8 months ago (2017-04-12 06:47:31 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-12 07:41:35 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c556f5a3a662c0b79ae7961f8bdb...

Powered by Google App Engine
This is Rietveld 408576698