Clean up webkitpy.common.checkout.git module.

Clean up webkitpy.common.checkout.git module.

Purpose: This is done to prepare to reuse the git executable init hack
in git cl so that rebaseline-cl works on Windows.

In this change:
 - Rename _run_git to run
 - Remove completely unused methods
 - Edit comments/docstrings

BUG=711088
Review-Url: https://codereview.chromium.org/2815093005
Cr-Commit-Position: refs/heads/master@{#464618}
Committed: https://chromium.googlesource.com/chromium/src/+/e5a158db9c3a0720c8390fc89df447b1b52d3d0f

[qyearsley, 2017-04-13 20:52:18]

Description was changed from

==========
Clean up git

BUG=
==========

to

==========
Clean up webkitpy.common.checkout.git module.

Purpose: This is done to prepare to reuse the git executable init hack
in git cl so that rebaseline-cl works on Windows.

In this change:
 - Rename _run_git to run
 - Remove completely unused methods
 - Edit comments/docstrings

BUG=711088
==========

[qyearsley, 2017-04-13 20:52:18]

qyearsley@chromium.org changed reviewers:
+ jeffcarp@chromium.org

[qyearsley, 2017-04-13 20:52:24]

The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-13 20:52:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jeffcarp, 2017-04-13 21:57:44]

lgtm with 1 nit and 1 suggestion

https://codereview.chromium.org/2815093005/diff/1/third_party/WebKit/Tools/Sc...
File third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/git.py (right):

https://codereview.chromium.org/2815093005/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/git.py:114: # The
Windows bots seem to through a WindowsError when git isn't installed.
I know this isn't part of your change but s/through/throw/

https://codereview.chromium.org/2815093005/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/git.py:117: #
_init_executable_name hack above.
If the issue is that executable_name isn't being set early enough, what about
making executable name a property method that does the check on the first
invocation?

def __init_(...):
    self._executable_name = None

@property
def executable_name(self):
    if self._executable_name:
        return self._executable_name

    try:
        self._executive.run_command(['git', 'help'])
        self._executable_name = 'git'
    except OSError:
        try:
            self._executive.run_command(['git.bat', 'help'])
            self._executable_name = 'git.bat'
        except OSError:
            _log.debug('Failed to engage git.bat Windows hack.')

    return self._executable_name

[commit-bot: I haz the power, 2017-04-13 21:58:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-13 21:58:34]

Dry run: This issue passed the CQ dry run.

[qyearsley, 2017-04-13 22:52:55]

The CQ bit was checked by qyearsley@chromium.org

[qyearsley, 2017-04-13 22:52:56]

The patchset sent to the CQ was uploaded after l-g-t-m from
jeffcarp@chromium.org
Link to the patchset: https://codereview.chromium.org/2815093005/#ps20001
(title: "git co wpt-import")

[qyearsley, 2017-04-13 22:53:09]

https://codereview.chromium.org/2815093005/diff/1/third_party/WebKit/Tools/Sc...
File third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/git.py (right):

https://codereview.chromium.org/2815093005/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/git.py:114: # The
Windows bots seem to through a WindowsError when git isn't installed.
On 2017/04/13 at 21:57:44, jeffcarp wrote:
> I know this isn't part of your change but s/through/throw/

Good catch, done

https://codereview.chromium.org/2815093005/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/git.py:117: #
_init_executable_name hack above.
On 2017/04/13 at 21:57:44, jeffcarp wrote:
> If the issue is that executable_name isn't being set early enough, what about
making executable name a property method that does the check on the first
invocation?
> 
> def __init_(...):
>     self._executable_name = None
> 
> @property
> def executable_name(self):
>     if self._executable_name:
>         return self._executable_name
> 
>     try:
>         self._executive.run_command(['git', 'help'])
>         self._executable_name = 'git'
>     except OSError:
>         try:
>             self._executive.run_command(['git.bat', 'help'])
>             self._executable_name = 'git.bat'
>         except OSError:
>             _log.debug('Failed to engage git.bat Windows hack.')
> 
>     return self._executable_name

Specifically what's happening here is that the class method in_working_directory
is called in the constructor before _init_executable_name is called - and since
in_working_directory is a class method it doesn't get access currently to any
instance variables.

In any case, I think that fixing this will be a separate change.

[commit-bot: I haz the power, 2017-04-13 22:53:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-14 00:09:37]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492123975933880,
"parent_rev": "fb69cfff512407b7d1e412a4a0ef71d9019daa8d", "commit_rev":
"e5a158db9c3a0720c8390fc89df447b1b52d3d0f"}

[commit-bot: I haz the power, 2017-04-14 00:10:50]

Description was changed from

==========
Clean up webkitpy.common.checkout.git module.

Purpose: This is done to prepare to reuse the git executable init hack
in git cl so that rebaseline-cl works on Windows.

In this change:
 - Rename _run_git to run
 - Remove completely unused methods
 - Edit comments/docstrings

BUG=711088
==========

to

==========
Clean up webkitpy.common.checkout.git module.

Purpose: This is done to prepare to reuse the git executable init hack
in git cl so that rebaseline-cl works on Windows.

In this change:
 - Rename _run_git to run
 - Remove completely unused methods
 - Edit comments/docstrings

BUG=711088

Review-Url: https://codereview.chromium.org/2815093005
Cr-Commit-Position: refs/heads/master@{#464618}
Committed:
https://chromium.googlesource.com/chromium/src/+/e5a158db9c3a0720c8390fc89df4...
==========

[commit-bot: I haz the power, 2017-04-14 00:10:52]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e5a158db9c3a0720c8390fc89df4...