Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/git_unittest.py

Issue 2815093005: Clean up webkitpy.common.checkout.git module. (Closed)
Patch Set: git co wpt-import Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/git.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/git_unittest.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/git_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/git_unittest.py
index 07f48959df8842fcade12bba01686c393df6e93c..87ce53cbb24a8c93acdfd29aad34662202fa09d8 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/git_unittest.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/git_unittest.py
@@ -198,8 +198,7 @@ class GitTestWithMock(unittest.TestCase):
def _assert_timestamp_of_revision(self, canned_git_output, expected):
git = self.make_git()
git.find_checkout_root = lambda path: ''
- # Modifying protected method. pylint: disable=protected-access
- git._run_git = lambda args: canned_git_output
+ git.run = lambda args: canned_git_output
self.assertEqual(git.timestamp_of_revision('some-path', '12345'), expected)
def test_timestamp_of_revision_utc(self):
@@ -222,8 +221,7 @@ class GitTestWithMock(unittest.TestCase):
'M d/modified-staged.txt',
'A d/added-staged.txt',
]
- # pylint: disable=protected-access
- git._run_git = lambda args: '\x00'.join(status_lines) + '\x00'
+ git.run = lambda args: '\x00'.join(status_lines) + '\x00'
self.assertEqual(
git.unstaged_changes(),
{
« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/git.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698