Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2815073003: Reland of Add back buttons and load new 'pages' by calling javascript. (Closed)

Created:
3 years, 8 months ago by BigBossZhiling
Modified:
3 years, 8 months ago
CC:
agrieve+watch_chromium.org, chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Add back buttons and load new 'pages' by calling javascript. (patchset #1 id:1 of https://codereview.chromium.org/2814903002/ ) Reason for reland: Error downstream has been fixed. So it should be able to reland now. TBR=mikecase@chromium.org,jbudorick@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. BUG=605572 Review-Url: https://codereview.chromium.org/2815073003 Cr-Commit-Position: refs/heads/master@{#464107} Committed: https://chromium.googlesource.com/chromium/src/+/e646a34701985a47d695ef0cbafdd8db5c7886e3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -27 lines) Patch
M build/android/pylib/results/presentation/javascript/main_html.js View 2 chunks +22 lines, -11 lines 0 comments Download
M build/android/pylib/results/presentation/template/main.html View 2 chunks +2 lines, -1 line 0 comments Download
M build/android/pylib/results/presentation/template/table.html View 2 chunks +4 lines, -0 lines 0 comments Download
M build/android/pylib/results/presentation/test_results_presentation.py View 4 chunks +27 lines, -15 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
BigBossZhiling
Created Reland of Add back buttons and load new 'pages' by calling javascript.
3 years, 8 months ago (2017-04-12 17:27:14 UTC) #1
jbudorick
On 2017/04/12 17:27:14, BigBossZhiling wrote: > Created Reland of Add back buttons and load new ...
3 years, 8 months ago (2017-04-12 17:30:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2815073003/1
3 years, 8 months ago (2017-04-12 17:35:00 UTC) #6
commit-bot: I haz the power
3 years, 8 months ago (2017-04-12 19:28:58 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e646a34701985a47d695ef0cbafd...

Powered by Google App Engine
This is Rietveld 408576698