Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(662)

Issue 2814903002: Revert of Add back buttons and load new 'pages' by calling javascript. (Closed)

Created:
3 years, 8 months ago by BigBossZhiling
Modified:
3 years, 8 months ago
CC:
agrieve+watch_chromium.org, chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add back buttons and load new 'pages' by calling javascript. (patchset #12 id:220001 of https://codereview.chromium.org/2799153008/ ) Reason for revert: Reverting because it broke stuff. Original issue's description: > Add back buttons and load new 'pages' by calling javascript. > > Previously when we want to see the details inside a specific suite, we > will go to a url '.../?suite=xxx'. This may not work in google storage. > > In this cl, I am changing the logic by calling javascript directly to > change the content of the page, if the user wants to see a specific > suite. > > Because we are not changing urls anymore, we need to have a "Back" > button to go back to the main page. > > BUG=605572 > > Review-Url: https://codereview.chromium.org/2799153008 > Cr-Commit-Position: refs/heads/master@{#463781} > Committed: https://chromium.googlesource.com/chromium/src/+/9b4e899d21ec602a49cd050b800085cd22130c69 TBR=mikecase@chromium.org,jbudorick@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=605572 Review-Url: https://codereview.chromium.org/2814903002 Cr-Commit-Position: refs/heads/master@{#463792} Committed: https://chromium.googlesource.com/chromium/src/+/ed038bc007f21c911007959447efa64fdfec4b3f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -55 lines) Patch
M build/android/pylib/results/presentation/javascript/main_html.js View 2 chunks +11 lines, -22 lines 0 comments Download
M build/android/pylib/results/presentation/template/main.html View 2 chunks +1 line, -2 lines 0 comments Download
M build/android/pylib/results/presentation/template/table.html View 2 chunks +0 lines, -4 lines 0 comments Download
M build/android/pylib/results/presentation/test_results_presentation.py View 4 chunks +15 lines, -27 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
BigBossZhiling
Created Revert of Add back buttons and load new 'pages' by calling javascript.
3 years, 8 months ago (2017-04-11 21:58:56 UTC) #1
jbudorick
lgtm
3 years, 8 months ago (2017-04-11 21:59:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2814903002/1
3 years, 8 months ago (2017-04-11 22:00:11 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/ed038bc007f21c911007959447efa64fdfec4b3f
3 years, 8 months ago (2017-04-11 22:05:49 UTC) #7
BigBossZhiling
3 years, 8 months ago (2017-04-12 17:27:14 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2815073003/ by hzl@google.com.

The reason for reverting is: Error downstream has been fixed. So it should be
able to reland now..

Powered by Google App Engine
This is Rietveld 408576698