Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Unified Diff: build/android/pylib/results/presentation/test_results_presentation.py

Issue 2814903002: Revert of Add back buttons and load new 'pages' by calling javascript. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/pylib/results/presentation/template/table.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/pylib/results/presentation/test_results_presentation.py
diff --git a/build/android/pylib/results/presentation/test_results_presentation.py b/build/android/pylib/results/presentation/test_results_presentation.py
index 3324784a4040100e77574208024121954943a889..ea51689f283bfe7a6ab8803da29f1f645751ea58 100755
--- a/build/android/pylib/results/presentation/test_results_presentation.py
+++ b/build/android/pylib/results/presentation/test_results_presentation.py
@@ -75,22 +75,6 @@
'class': html_class,
'links': links,
'rowspan': rowspan,
- }
-
-
-def action_cell(action, data, html_class):
- """Formats table cell with javascript actions.
-
- Args:
- action: Javscript action.
- data: Data in cell.
- class: Class for table cell.
- """
- return {
- 'cell_type': 'action',
- 'action': action,
- 'data': data,
- 'class': html_class,
}
@@ -181,11 +165,13 @@
]
footer_row = [
- action_cell(
- 'showTestsOfOneSuiteOnlyWithNewState("TOTAL")',
- 'TOTAL',
- 'center'
- ), # TOTAL
+ links_cell(
+ links=[
+ link(href=('?suite=%s' % 'TOTAL'),
+ target=LinkTarget.CURRENT_TAB,
+ data='TOTAL')
+ ],
+ ), # suite_name
cell(data=0), # number_success_tests
cell(data=0), # number_fail_tests
cell(data=0), # all_tests
@@ -205,10 +191,12 @@
suite_row = suite_row_dict[suite_name]
else:
suite_row = [
- action_cell(
- 'showTestsOfOneSuiteOnlyWithNewState("%s")' % suite_name,
- suite_name,
- 'left'
+ links_cell(
+ links=[
+ link(href=('?suite=%s' % suite_name),
+ target=LinkTarget.CURRENT_TAB,
+ data=suite_name)],
+ html_class='left'
), # suite_name
cell(data=0), # number_success_tests
cell(data=0), # number_fail_tests
@@ -311,13 +299,13 @@
parser.add_argument('--json-file', help='Path of json file.', required=True)
parser.add_argument('--cs-base-url', help='Base url for code search.',
default='http://cs.chromium.org')
- parser.add_argument('--bucket', help='Google storage bucket.', required=True)
+ parser.add_argument('--bucket', default='chromium-result-details')
parser.add_argument('--builder-name', help='Builder name.', required=True)
parser.add_argument('--build-number', help='Build number.', required=True)
parser.add_argument('--test-name', help='The name of the test.',
required=True)
parser.add_argument('--server-url', help='The url of the server.',
- default='https://storage.cloud.google.com')
+ default='https://storage.googleapis.com')
parser.add_argument(
'--content-type',
help=('Content type, which is used to determine '
« no previous file with comments | « build/android/pylib/results/presentation/template/table.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698