Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2814873002: Revert of Enable strict coverage for step module (Closed)

Created:
3 years, 8 months ago by Paweł Hajdan Jr.
Modified:
3 years, 8 months ago
Reviewers:
iannucci
CC:
chromium-reviews, infra-reviews+recipes-py_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert of Enable strict coverage for step module (patchset #3 id:40001 of https://codereview.chromium.org/2806363004/ ) Reason for revert: Fails downstream, e.g. build: Exception: While generating results for 'swarming:tests/results_merger_unittest': TypeError: 'NoneType' object is not callable Looks like it's picking up unrelated swarming tests... Original issue's description: > Enable strict coverage for step module > > BUG=chromium:693058 > > Review-Url: https://codereview.chromium.org/2806363004 > Committed: https://github.com/luci/recipes-py/commit/3bd327959845d8cb93d1987b3da790a20384a1e1 TBR=iannucci@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:693058 Review-Url: https://codereview.chromium.org/2814873002 Committed: https://github.com/luci/recipes-py/commit/939068138596e0259bd19be9e40c1ab17f55b3d6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+307 lines, -467 lines) Patch
M recipe_engine/loader.py View 2 chunks +11 lines, -23 lines 0 comments Download
M recipe_engine/unittests/run_test.py View 4 chunks +4 lines, -4 lines 0 comments Download
M recipe_modules/step/__init__.py View 1 chunk +7 lines, -0 lines 0 comments Download
D recipe_modules/step/tests/active_result.py View 1 chunk +0 lines, -17 lines 0 comments Download
D recipe_modules/step/tests/active_result.expected/basic.json View 1 chunk +0 lines, -17 lines 0 comments Download
D recipe_modules/step/tests/defer.py View 1 chunk +0 lines, -26 lines 0 comments Download
D recipe_modules/step/tests/defer.expected/basic.json View 1 chunk +0 lines, -21 lines 0 comments Download
D recipe_modules/step/tests/defer.expected/one_fail.json View 1 chunk +0 lines, -26 lines 0 comments Download
D recipe_modules/step/tests/nested.py View 1 chunk +0 lines, -41 lines 0 comments Download
D recipe_modules/step/tests/nested.expected/basic.json View 1 chunk +0 lines, -88 lines 0 comments Download
D recipe_modules/step/tests/stdio.py View 1 chunk +0 lines, -33 lines 0 comments Download
D recipe_modules/step/tests/stdio.expected/basic.json View 1 chunk +0 lines, -32 lines 0 comments Download
D recipe_modules/step/tests/subannotations.py View 1 chunk +0 lines, -14 lines 0 comments Download
D recipe_modules/step/tests/subannotations.expected/basic.json View 1 chunk +0 lines, -22 lines 0 comments Download
D recipe_modules/step/tests/timeout.py View 1 chunk +0 lines, -34 lines 0 comments Download
D recipe_modules/step/tests/timeout.expected/timeout.json View 1 chunk +0 lines, -20 lines 0 comments Download
D recipe_modules/step/tests/trigger.py View 1 chunk +0 lines, -28 lines 0 comments Download
D recipe_modules/step/tests/trigger.expected/basic.json View 1 chunk +0 lines, -21 lines 0 comments Download
A recipes/engine_tests/subannotations.py View 1 chunk +12 lines, -0 lines 0 comments Download
A recipes/engine_tests/subannotations.expected/basic.json View 1 chunk +22 lines, -0 lines 0 comments Download
A recipes/engine_tests/trigger.py View 1 chunk +28 lines, -0 lines 0 comments Download
A recipes/engine_tests/trigger.expected/basic.json View 1 chunk +21 lines, -0 lines 0 comments Download
A recipes/example/defer.py View 1 chunk +26 lines, -0 lines 0 comments Download
A recipes/example/defer.expected/basic.json View 1 chunk +21 lines, -0 lines 0 comments Download
A recipes/example/defer.expected/one_fail.json View 1 chunk +26 lines, -0 lines 0 comments Download
A recipes/example/nested.py View 1 chunk +41 lines, -0 lines 0 comments Download
A recipes/example/nested.expected/basic.json View 1 chunk +88 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Paweł Hajdan Jr.
Created Revert of Enable strict coverage for step module
3 years, 8 months ago (2017-04-11 20:38:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2814873002/1
3 years, 8 months ago (2017-04-11 20:38:49 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-04-11 20:39:05 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/recipes-py/commit/939068138596e0259bd19be9e40c1ab17f5...

Powered by Google App Engine
This is Rietveld 408576698