Enable strict coverage for step module

Enable strict coverage for step module

BUG=chromium:693058
Review-Url: https://codereview.chromium.org/2806363004
Committed: https://github.com/luci/recipes-py/commit/3bd327959845d8cb93d1987b3da790a20384a1e1

[Paweł Hajdan Jr., 2017-04-11 19:56:14]

The CQ bit was checked by phajdan.jr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-11 19:56:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-11 20:03:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-11 20:03:22]

Dry run: Try jobs failed on following builders:
  Recipes-py Presubmit on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/35776b1aa8b7a210)

[Paweł Hajdan Jr., 2017-04-11 20:04:56]

The CQ bit was checked by phajdan.jr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-11 20:05:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[iannucci1, 2017-04-11 20:06:26]

iannucci@google.com changed reviewers:
+ iannucci@google.com

[iannucci1, 2017-04-11 20:06:27]

lgtm w/ test name change

https://codereview.chromium.org/2806363004/diff/1/recipe_engine/loader.py
File recipe_engine/loader.py (right):

https://codereview.chromium.org/2806363004/diff/1/recipe_engine/loader.py#new...
recipe_engine/loader.py:245: recipe_path = os.path.join(module_dir, 'tests',
recipe_name + '.py')
let's just change this to have less magic, so the test name would be:
`foo:tests/something` for the foo module's `tests/something.py`.

It's still fine to have the special case below for the loader though (so `tests`
is reserved for recipes).

[Paweł Hajdan Jr., 2017-04-11 20:06:28]

phajdan.jr@chromium.org changed reviewers:
+ iannucci@chromium.org
- iannucci@google.com

[commit-bot: I haz the power, 2017-04-11 20:08:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-11 20:08:32]

Dry run: This issue passed the CQ dry run.

[Paweł Hajdan Jr., 2017-04-11 20:14:01]

https://codereview.chromium.org/2806363004/diff/1/recipe_engine/loader.py
File recipe_engine/loader.py (right):

https://codereview.chromium.org/2806363004/diff/1/recipe_engine/loader.py#new...
recipe_engine/loader.py:245: recipe_path = os.path.join(module_dir, 'tests',
recipe_name + '.py')
On 2017/04/11 20:06:27, iannucci1 wrote:
> let's just change this to have less magic, so the test name would be:
> `foo:tests/something` for the foo module's `tests/something.py`.
> 
> It's still fine to have the special case below for the loader though (so
`tests`
> is reserved for recipes).

Done.

[Paweł Hajdan Jr., 2017-04-11 20:14:08]

The CQ bit was checked by phajdan.jr@chromium.org

[Paweł Hajdan Jr., 2017-04-11 20:14:08]

The patchset sent to the CQ was uploaded after l-g-t-m from iannucci@google.com
Link to the patchset: https://codereview.chromium.org/2806363004/#ps40001
(title: "review")

[commit-bot: I haz the power, 2017-04-11 20:14:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-11 20:17:50]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1491941648147950,
"parent_rev": "05d9ed6145e2b05b7430fb7306f279fb2e2f19b2", "commit_rev":
"3bd327959845d8cb93d1987b3da790a20384a1e1"}

[commit-bot: I haz the power, 2017-04-11 20:17:57]

Description was changed from

==========
Enable strict coverage for step module

BUG=chromium:693058
==========

to

==========
Enable strict coverage for step module

BUG=chromium:693058

Review-Url: https://codereview.chromium.org/2806363004
Committed:
https://github.com/luci/recipes-py/commit/3bd327959845d8cb93d1987b3da790a2038...
==========

[commit-bot: I haz the power, 2017-04-11 20:17:58]

Committed patchset #3 (id:40001) as
https://github.com/luci/recipes-py/commit/3bd327959845d8cb93d1987b3da790a2038...

[iannucci, 2017-04-11 20:18:44]

lgtm

[Paweł Hajdan Jr., 2017-04-11 20:38:41]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2814873002/ by phajdan.jr@chromium.org.

The reason for reverting is: Fails downstream, e.g. build:

Exception: While generating results for
'swarming:tests/results_merger_unittest': TypeError: 'NoneType' object is not
callable

Looks like it's picking up unrelated swarming tests....