Chromium Code Reviews Chromium Code Reviews
Issue 2814733002:
Add the SocEng as a type for checking in CheckUrlForSubresourceFilter. (Closed)
| Index: tools/metrics/histograms/histograms.xml |
| diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml |
| index cb4d84f193dce7c28ce4ce179d3e1b0630bf46f7..b6b3b50326171cf84b623c5952818677fa3d85f6 100644 |
| --- a/tools/metrics/histograms/histograms.xml |
| +++ b/tools/metrics/histograms/histograms.xml |
| @@ -70926,6 +70926,9 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries. |
| <histogram name="SubresourceFilter.PageLoad.RedirectChainMatchPattern" |
| enum="SubresourceFilterMatchPattern"> |
| + <obsolete> |
| + Obsolete, since the don't have correct data to record anymore. |
| + </obsolete> |
| <owner>melandory@chromium.org</owner> |
| <summary> |
| For each main frame navigation, records a pattern that indicates which URLs |
| @@ -71021,6 +71024,14 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries. |
| </summary> |
| </histogram> |
| +<histogram name="SubresourecFilter.PageLoad.FinalURLMatch" units="matches"> |
| + <owner>melandory@chromium.org</owner> |
| + <summary> |
| + Records the fact of a match of the last url in the redirect chain for the |
|
engedy
2017/04/26 13:47:10
Phrasing nit: Records, for each main frame navigat
melandory
2017/04/26 15:02:21
Done.
|
| + main frame. |
| + </summary> |
| +</histogram> |
| + |
| <histogram name="Suggestions.FailedRequestErrorCode" enum="NetErrorCodes"> |
| <owner>mathp@chromium.org</owner> |
| <summary> |
| @@ -127168,13 +127179,12 @@ from previous Chrome versions. |
| </histogram_suffixes> |
| <histogram_suffixes name="SubresourceFilterOnlyExperiment" separator="."> |
| + <affected-histogram name="SubresourceFilter.PageLoad.RedirectChainLength"/> |
| <suffix name="SocialEngineeringAdsInterstitial" |
| label="social eng ad blacklist pattern"/> |
| <suffix name="PhishingInterstitial" label="phishing blacklist pattern"/> |
| - <suffix name="SubresourceFilterOnly" label="subresource filter only patern"/> |
| - <affected-histogram name="SubresourceFilter.PageLoad.RedirectChainLength"/> |
| - <affected-histogram |
| - name="SubresourceFilter.PageLoad.RedirectChainMatchPattern"/> |
| + <suffix name="SubresourceFilterOnly" label="subresource filter only pattern"/> |
| + <affected-histogram name="SubresourecFilter.PageLoad.FinalURLMatch"/> |
| </histogram_suffixes> |
| <histogram_suffixes name="SyncModelType" separator="."> |
