Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(911)

Unified Diff: components/subresource_filter/content/renderer/subresource_filter_agent.cc

Issue 2814733002: Add the SocEng as a type for checking in CheckUrlForSubresourceFilter. (Closed)
Patch Set: . Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/subresource_filter/content/renderer/subresource_filter_agent.cc
diff --git a/components/subresource_filter/content/renderer/subresource_filter_agent.cc b/components/subresource_filter/content/renderer/subresource_filter_agent.cc
index c9b47d511775592418c01a6abfaaae09d69e9a07..35b6475d4c30573dabb2cd43fcdb257b1be94bbd 100644
--- a/components/subresource_filter/content/renderer/subresource_filter_agent.cc
+++ b/components/subresource_filter/content/renderer/subresource_filter_agent.cc
@@ -64,7 +64,7 @@ void SubresourceFilterAgent::OnActivateForNextCommittedLoad(
activation_state_for_next_commit_ = activation_state;
}
-void SubresourceFilterAgent::RecordHistogramsOnLoadCommitted() {
+void SubresourceFilterAgent::RecordedHistogramsOnLoadCommitted() {
// Note: ActivationLevel used to be called ActivationState, the legacy name is
// kept for the histogram.
ActivationLevel activation_level =
@@ -79,7 +79,7 @@ void SubresourceFilterAgent::RecordHistogramsOnLoadCommitted() {
}
}
-void SubresourceFilterAgent::RecordHistogramsOnLoadFinished() {
+void SubresourceFilterAgent::RecordedHistogramsOnLoadFinished() {
DCHECK(filter_for_last_committed_load_);
const auto& statistics =
filter_for_last_committed_load_->filter().statistics();
@@ -143,7 +143,7 @@ void SubresourceFilterAgent::DidCommitProvisionalLoad(
// which require changes to the unit tests.
const GURL& url = GetDocumentURL();
if (url.SchemeIsHTTPOrHTTPS() || url.SchemeIsFile()) {
- RecordHistogramsOnLoadCommitted();
+ RecordedHistogramsOnLoadCommitted();
if (activation_state_for_next_commit_.activation_level !=
ActivationLevel::DISABLED &&
ruleset_dealer_->IsRulesetFileAvailable()) {
@@ -175,7 +175,7 @@ void SubresourceFilterAgent::DidFailProvisionalLoad(
void SubresourceFilterAgent::DidFinishLoad() {
if (!filter_for_last_committed_load_)
return;
- RecordHistogramsOnLoadFinished();
+ RecordedHistogramsOnLoadFinished();
}
bool SubresourceFilterAgent::OnMessageReceived(const IPC::Message& message) {

Powered by Google App Engine
This is Rietveld 408576698