components/subresource_filter/content/renderer/subresource_filter_agent.h - Issue 2814733002: Add the SocEng as a type for checking in CheckUrlForSubresourceFilter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/subresource_filter/content/renderer/subresource_filter_agent.h

Issue 2814733002: Add the SocEng as a type for checking in CheckUrlForSubresourceFilter. (Closed)

Patch Set: . Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/subresource_filter/content/browser/subresource_filter_safe_browsing_activation_throttle_unittest.cc ('K') | « components/subresource_filter/content/browser/subresource_filter_safe_browsing_activation_throttle_unittest.cc ('k') | components/subresource_filter/content/renderer/subresource_filter_agent.cc » ('j') | tools/metrics/histograms/histograms.xml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/subresource_filter/content/renderer/subresource_filter_agent.h

diff --git a/components/subresource_filter/content/renderer/subresource_filter_agent.h b/components/subresource_filter/content/renderer/subresource_filter_agent.h

index 22bc3fc2a8d0d677ef810ad345d93e5c7556433d..e0c4927b75d0b160b4e7f7a9efe880a1ccdd89a9 100644

--- a/components/subresource_filter/content/renderer/subresource_filter_agent.h

+++ b/components/subresource_filter/content/renderer/subresource_filter_agent.h

@@ -58,8 +58,8 @@ class SubresourceFilterAgent

private:

void OnActivateForNextCommittedLoad(ActivationState activation_state);

- void RecordHistogramsOnLoadCommitted();

- void RecordHistogramsOnLoadFinished();

+ void RecordedHistogramsOnLoadCommitted();

engedy 2017/04/26 13:47:10 nit: I think accidental rename?

melandory 2017/04/26 15:02:21 Done.

+ void RecordedHistogramsOnLoadFinished();

void ResetActivatonStateForNextCommit();

// content::RenderFrameObserver: