Media Controls: move time display elements to media_controls module.

Media Controls: move time display elements to media_controls module.

This is moving the two elements using MediaControlTimeDisplayElement to
the modules directory. The base class will be moved later as it is used
in the accessibility code.

BUG=662761
R=avayvod@chromium.org

Review-Url: https://codereview.chromium.org/2814703002
Cr-Commit-Position: refs/heads/master@{#463859}
Committed: https://chromium.googlesource.com/chromium/src/+/5b02781acf9884bcbea21eb0b7c6de8dfd34d0a0

[mlamouri (slow - plz ping), 2017-04-11 10:43:07]

The CQ bit was checked by mlamouri@chromium.org to run a CQ dry run

[mlamouri (slow - plz ping), 2017-04-11 10:43:13]

PTAL

[commit-bot: I haz the power, 2017-04-11 10:43:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-11 12:22:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-11 12:22:33]

Dry run: This issue passed the CQ dry run.

[Srirama, 2017-04-11 13:13:28]

srirama.m@samsung.com changed reviewers:
+ srirama.m@samsung.com

[Srirama, 2017-04-11 13:13:28]

https://codereview.chromium.org/2814703002/diff/1/third_party/WebKit/Source/m...
File
third_party/WebKit/Source/modules/media_controls/elements/MediaControlTimeRemainingDisplayElement.h
(right):

https://codereview.chromium.org/2814703002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/media_controls/elements/MediaControlTimeRemainingDisplayElement.h:5:
#ifndef MediaControlTimeRemainingDisplayElement_h
Just a thought, if it makes sense to rename these files as ***RemainingTime***
from ***TimeRemaining*** to align with ***CurrentTime*** files.

[whywhat, 2017-04-11 15:09:33]

lgtm

https://codereview.chromium.org/2814703002/diff/1/third_party/WebKit/Source/m...
File
third_party/WebKit/Source/modules/media_controls/elements/MediaControlTimeRemainingDisplayElement.h
(right):

https://codereview.chromium.org/2814703002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/media_controls/elements/MediaControlTimeRemainingDisplayElement.h:5:
#ifndef MediaControlTimeRemainingDisplayElement_h
On 2017/04/11 at 13:13:28, Srirama wrote:
> Just a thought, if it makes sense to rename these files as ***RemainingTime***
from ***TimeRemaining*** to align with ***CurrentTime*** files.

TBH, using inheritance for these two classes sounds like overengineering :)
Could just pass the right pseudo-id and kMediaCurrent/RemainingTimeDisplay to
the base class ctor.

[mlamouri (slow - plz ping), 2017-04-11 22:25:35]

The CQ bit was checked by mlamouri@chromium.org

[mlamouri (slow - plz ping), 2017-04-11 22:25:36]

The patchset sent to the CQ was uploaded after l-g-t-m from avayvod@chromium.org
Link to the patchset: https://codereview.chromium.org/2814703002/#ps20001
(title: "review comments")

[mlamouri (slow - plz ping), 2017-04-11 22:25:57]

https://codereview.chromium.org/2814703002/diff/1/third_party/WebKit/Source/m...
File
third_party/WebKit/Source/modules/media_controls/elements/MediaControlTimeRemainingDisplayElement.h
(right):

https://codereview.chromium.org/2814703002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/media_controls/elements/MediaControlTimeRemainingDisplayElement.h:5:
#ifndef MediaControlTimeRemainingDisplayElement_h
On 2017/04/11 at 15:09:33, whywhat wrote:
> On 2017/04/11 at 13:13:28, Srirama wrote:
> > Just a thought, if it makes sense to rename these files as
***RemainingTime*** from ***TimeRemaining*** to align with ***CurrentTime***
files.

Done.

> TBH, using inheritance for these two classes sounds like overengineering :)
> Could just pass the right pseudo-id and kMediaCurrent/RemainingTimeDisplay to
the base class ctor.

I tend to agree but instead of just changing these two classes in the middle of
moving all the code, maybe we could look into this later if it still sounds
useful. At least, here we have consistency between the elements and the caller
only need to call the ctor.

[commit-bot: I haz the power, 2017-04-11 22:26:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[whywhat, 2017-04-11 22:31:09]

https://codereview.chromium.org/2814703002/diff/1/third_party/WebKit/Source/m...
File
third_party/WebKit/Source/modules/media_controls/elements/MediaControlTimeRemainingDisplayElement.h
(right):

https://codereview.chromium.org/2814703002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/media_controls/elements/MediaControlTimeRemainingDisplayElement.h:5:
#ifndef MediaControlTimeRemainingDisplayElement_h
On 2017/04/11 at 22:25:57, mlamouri wrote:
> On 2017/04/11 at 15:09:33, whywhat wrote:
> > On 2017/04/11 at 13:13:28, Srirama wrote:
> > > Just a thought, if it makes sense to rename these files as
***RemainingTime*** from ***TimeRemaining*** to align with ***CurrentTime***
files.
> 
> Done.
> 
> > TBH, using inheritance for these two classes sounds like overengineering :)
> > Could just pass the right pseudo-id and kMediaCurrent/RemainingTimeDisplay
to the base class ctor.
> 
> I tend to agree but instead of just changing these two classes in the middle
of moving all the code, maybe we could look into this later if it still sounds
useful. At least, here we have consistency between the elements and the caller
only need to call the ctor.

I should've clarified I didn't mean to change that in this cl :)

[commit-bot: I haz the power, 2017-04-12 00:40:11]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491949535826110,
"parent_rev": "01a26dbc005c5109ee96a571e8d3137e17d753a5", "commit_rev":
"5b02781acf9884bcbea21eb0b7c6de8dfd34d0a0"}

[commit-bot: I haz the power, 2017-04-12 00:45:17]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491949535826110,
"parent_rev": "01a26dbc005c5109ee96a571e8d3137e17d753a5", "commit_rev":
"5b02781acf9884bcbea21eb0b7c6de8dfd34d0a0"}

[commit-bot: I haz the power, 2017-04-12 00:45:20]

Description was changed from

==========
Media Controls: move time display elements to media_controls module.

This is moving the two elements using MediaControlTimeDisplayElement to
the modules directory. The base class will be moved later as it is used
in the accessibility code.

BUG=662761
R=avayvod@chromium.org
==========

to

==========
Media Controls: move time display elements to media_controls module.

This is moving the two elements using MediaControlTimeDisplayElement to
the modules directory. The base class will be moved later as it is used
in the accessibility code.

BUG=662761
R=avayvod@chromium.org

Review-Url: https://codereview.chromium.org/2814703002
Cr-Commit-Position: refs/heads/master@{#463859}
Committed:
https://chromium.googlesource.com/chromium/src/+/5b02781acf9884bcbea21eb0b7c6...
==========

[commit-bot: I haz the power, 2017-04-12 00:45:22]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/5b02781acf9884bcbea21eb0b7c6...