third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.h - Issue 2814703002: Media Controls: move time display elements to media_controls module.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.h

Issue 2814703002: Media Controls: move time display elements to media_controls module. (Closed)

Patch Set: review comments Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/media_controls/BUILD.gn ('k') | third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.h

diff --git a/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.h b/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.h

index bf839b5f67ef1f5f8fc28653b7a0412e448017ba..629a236a9c63e7707551e80dc22267a7a9b6f432 100644

--- a/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.h

+++ b/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.h

@@ -38,9 +38,11 @@ class Event;

class MediaControlsMediaEventListener;

class MediaControlsOrientationLockDelegate;

class MediaControlsWindowEventListener;

+class MediaControlCurrentTimeDisplayElement;

class MediaControlMuteButtonElement;

class MediaControlOverlayEnclosureElement;

class MediaControlPanelEnclosureElement;

+class MediaControlRemainingTimeDisplayElement;

class ShadowRoot;

// Default implementation of the core/ MediaControls interface used by

@@ -209,7 +211,7 @@ class MODULES_EXPORT MediaControlsImpl final : public HTMLDivElement,

Member<MediaControlPlayButtonElement> play_button_;

Member<MediaControlTimelineElement> timeline_;

Member<MediaControlCurrentTimeDisplayElement> current_time_display_;

- Member<MediaControlTimeRemainingDisplayElement> duration_display_;

+ Member<MediaControlRemainingTimeDisplayElement> duration_display_;

Member<MediaControlMuteButtonElement> mute_button_;

Member<MediaControlVolumeSliderElement> volume_slider_;

Member<MediaControlToggleClosedCaptionsButtonElement>