Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 2814673002: Use ASCII-caseless matching for attribute names. (Closed)

Created:
3 years, 8 months ago by tkent
Modified:
3 years, 8 months ago
Reviewers:
kochi
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-w3ctests_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, kinuko+watch, rwlbuis, sof
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use ASCII-caseless matching for attribute names. We applied Unicode-caseless matching unnecessarily. New behavior matches to the DOM standard, Edge, Firefox, and Safari. This CL renames EqualPossiblyIgnoringCase() and QualifedName:: MatchesPossiblyIgnoringCase() so that their names represent ASCII caseless matching. BUG=502301, 627682 Review-Url: https://codereview.chromium.org/2814673002 Cr-Commit-Position: refs/heads/master@{#463595} Committed: https://chromium.googlesource.com/chromium/src/+/06c1ecad600e9ac12f28d1ed1433d9d93c067a30

Patch Set 1 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -23 lines) Patch
M third_party/WebKit/LayoutTests/external/wpt/dom/nodes/case-expected.txt View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/AttributeCollection.h View 2 chunks +6 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Element.cpp View 6 chunks +7 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/dom/QualifiedName.h View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/wtf/text/WTFString.h View 2 chunks +7 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/wtf/text/WTFString.cpp View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (18 generated)
tkent
kochi@, would you review this please?
3 years, 8 months ago (2017-04-11 09:03:53 UTC) #14
kochi
lgtm
3 years, 8 months ago (2017-04-11 10:37:27 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2814673002/40001
3 years, 8 months ago (2017-04-11 10:39:22 UTC) #19
commit-bot: I haz the power
3 years, 8 months ago (2017-04-11 10:44:55 UTC) #22
Message was sent while issue was closed.
Committed patchset #1 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/06c1ecad600e9ac12f28d1ed1433...

Powered by Google App Engine
This is Rietveld 408576698