Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Unified Diff: third_party/WebKit/Source/core/dom/Element.cpp

Issue 2814673002: Use ASCII-caseless matching for attribute names. (Closed)
Patch Set: . Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/Element.cpp
diff --git a/third_party/WebKit/Source/core/dom/Element.cpp b/third_party/WebKit/Source/core/dom/Element.cpp
index a2390f6390500a66411bcdf3d0d29807dc3f0715..869b1be969768d3e7306b3d76ae7d7164bbfb6b5 100644
--- a/third_party/WebKit/Source/core/dom/Element.cpp
+++ b/third_party/WebKit/Source/core/dom/Element.cpp
@@ -393,8 +393,8 @@ void Element::SynchronizeAttribute(const AtomicString& local_name) const {
if (!GetElementData())
return;
if (GetElementData()->style_attribute_is_dirty_ &&
- EqualPossiblyIgnoringCase(local_name, styleAttr.LocalName(),
- ShouldIgnoreAttributeCase())) {
+ EqualPossiblyIgnoringASCIICase(local_name, styleAttr.LocalName(),
+ ShouldIgnoreAttributeCase())) {
DCHECK(IsStyledElement());
SynchronizeStyleAttributeInternal();
return;
@@ -1243,7 +1243,7 @@ void Element::setAttribute(const AtomicString& local_name,
SynchronizeAttribute(local_name);
const AtomicString& case_adjusted_local_name =
- ShouldIgnoreAttributeCase() ? local_name.DeprecatedLower() : local_name;
+ ShouldIgnoreAttributeCase() ? local_name.LowerASCII() : local_name;
if (!GetElementData()) {
SetAttributeInternal(
@@ -2463,7 +2463,7 @@ Attr* Element::setAttributeNode(Attr* attr_node,
}
if (!IsHTMLElement() && attr_node->GetDocument().IsHTMLDocument() &&
- attr_node->name() != attr_node->name().DeprecatedLower())
+ attr_node->name() != attr_node->name().LowerASCII())
UseCounter::Count(
GetDocument(),
UseCounter::
@@ -2630,7 +2630,7 @@ void Element::removeAttribute(const AtomicString& name) {
return;
AtomicString local_name =
- ShouldIgnoreAttributeCase() ? name.DeprecatedLower() : name;
+ ShouldIgnoreAttributeCase() ? name.LowerASCII() : name;
size_t index = GetElementData()->Attributes().FindIndex(local_name, false);
if (index == kNotFound) {
if (UNLIKELY(local_name == styleAttr) &&
@@ -2675,8 +2675,7 @@ bool Element::hasAttribute(const AtomicString& local_name) const {
return false;
SynchronizeAttribute(local_name);
return GetElementData()->Attributes().FindIndex(
- ShouldIgnoreAttributeCase() ? local_name.DeprecatedLower()
- : local_name,
+ ShouldIgnoreAttributeCase() ? local_name.LowerASCII() : local_name,
false) != kNotFound;
}
@@ -3888,7 +3887,7 @@ Attr* Element::AttrIfExists(const QualifiedName& name) {
if (AttrNodeList* attr_node_list = this->GetAttrNodeList()) {
bool should_ignore_case = ShouldIgnoreAttributeCase();
for (const auto& attr : *attr_node_list) {
- if (attr->GetQualifiedName().MatchesPossiblyIgnoringCase(
+ if (attr->GetQualifiedName().MatchesPossiblyIgnoringASCIICase(
name, should_ignore_case))
return attr.Get();
}
« no previous file with comments | « third_party/WebKit/Source/core/dom/AttributeCollection.h ('k') | third_party/WebKit/Source/core/dom/QualifiedName.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698