Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 2814623003: Revert of [Payments] update strings (Closed)

Created:
3 years, 8 months ago by Mike West
Modified:
3 years, 8 months ago
CC:
chromium-reviews, mahmadi+paymentswatch_chromium.org, rouslan+payments_chromium.org, sebsg+paymentswatch_chromium.org, gogerald+paymentswatch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Payments] update strings (patchset #2 id:40001 of https://codereview.chromium.org/2812523004/ ) Reason for revert: This broke some Android tests in https://uberchromegw.corp.google.com/i/chromium.linux/builders/Android%20Tests/builds/40425 (I guess they have hard-coded strings?) Original issue's description: > update strings > > Update payments related strings according to this doc: > https://docs.google.com/a/google.com/document/d/18sbGGysw9SSFHv_cYebZlK9uIbxdRMyD2t4EMCzpxcY/edit?usp=sharing > > BUG=710175 > > Review-Url: https://codereview.chromium.org/2812523004 > Cr-Commit-Position: refs/heads/master@{#463462} > Committed: https://chromium.googlesource.com/chromium/src/+/36b88dcdf796a4bd6b2442f11a44d453c54d7e65 TBR=srahim@chromium.org,rouslan@chromium.org,gogerald@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=710175 Review-Url: https://codereview.chromium.org/2814623003 Cr-Commit-Position: refs/heads/master@{#463558} Committed: https://chromium.googlesource.com/chromium/src/+/860f7b94d494e56b79f9eb0de666e3055d19b309

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -50 lines) Patch
M components/payments_strings.grdp View 8 chunks +50 lines, -50 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
Mike West
Created Revert of [Payments] update strings
3 years, 8 months ago (2017-04-11 07:05:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2814623003/1
3 years, 8 months ago (2017-04-11 07:05:41 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-04-11 07:17:13 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/860f7b94d494e56b79f9eb0de666...

Powered by Google App Engine
This is Rietveld 408576698