Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2812523004:
[Payments] update strings (Closed)
|
Created:
3 years, 8 months ago by gogerald1 Modified:
3 years, 8 months ago CC:
chromium-reviews, mahmadi+paymentswatch_chromium.org, rouslan+payments_chromium.org, sebsg+paymentswatch_chromium.org, gogerald+paymentswatch_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
Descriptionupdate strings
Update payments related strings according to this doc:
https://docs.google.com/a/google.com/document/d/18sbGGysw9SSFHv_cYebZlK9uIbxdRMyD2t4EMCzpxcY/edit?usp=sharing
BUG=710175
Review-Url: https://codereview.chromium.org/2812523004
Cr-Original-Commit-Position: refs/heads/master@{#463462}
Committed: https://chromium.googlesource.com/chromium/src/+/36b88dcdf796a4bd6b2442f11a44d453c54d7e65
Review-Url: https://codereview.chromium.org/2812523004
Cr-Commit-Position: refs/heads/master@{#463625}
Committed: https://chromium.googlesource.com/chromium/src/+/41de7075b5df44532a910a912d76550a32bad708
Patch Set 1 #
Total comments: 6
Patch Set 2 : address comments #Patch Set 3 : fix tests #
Messages
Total messages: 37 (27 generated)
Description was changed from ========== update strings BUG= ========== to ========== update strings Update payments related strings according to this doc: https://docs.google.com/a/google.com/document/d/18sbGGysw9SSFHv_cYebZlK9uIbxd... BUG= ==========
Patchset #1 (id:1) has been deleted
The CQ bit was checked by gogerald@chromium.org to run a CQ dry run
gogerald@chromium.org changed reviewers: + srahim@chromium.org
Hi srahim@, ptal,
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== update strings Update payments related strings according to this doc: https://docs.google.com/a/google.com/document/d/18sbGGysw9SSFHv_cYebZlK9uIbxd... BUG= ========== to ========== update strings Update payments related strings according to this doc: https://docs.google.com/a/google.com/document/d/18sbGGysw9SSFHv_cYebZlK9uIbxd... BUG=710175 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
A few more edits are needed. Otherwise, LGTM. Thanks! https://codereview.chromium.org/2812523004/diff/20001/components/payments_str... File components/payments_strings.grdp (right): https://codereview.chromium.org/2812523004/diff/20001/components/payments_str... components/payments_strings.grdp:116: Name on Card Change the string "Name on Card" to "Cardholder Name" to match the IDS_PAYMENTS_NAME_ON_CARD_REQUIRED. https://codereview.chromium.org/2812523004/diff/20001/components/payments_str... components/payments_strings.grdp:222: Select a shipping address to check shipping methods and requirements. String edit from doc: "To see shipping methods and requirements, select an address" No period if it's a single sentence appearing by itself. https://codereview.chromium.org/2812523004/diff/20001/components/payments_str... components/payments_strings.grdp:271: Can’t open payment app. Minor nit: if this is a single sentence, and no other sentences appear with it, remove period per Google style.
gogerald@chromium.org changed reviewers: + rouslan@chromium.org
Hi rouslan@, ptal https://codereview.chromium.org/2812523004/diff/20001/components/payments_str... File components/payments_strings.grdp (right): https://codereview.chromium.org/2812523004/diff/20001/components/payments_str... components/payments_strings.grdp:116: Name on Card On 2017/04/10 22:06:38, srahim wrote: > Change the string "Name on Card" to "Cardholder Name" to match the > IDS_PAYMENTS_NAME_ON_CARD_REQUIRED. Done. https://codereview.chromium.org/2812523004/diff/20001/components/payments_str... components/payments_strings.grdp:222: Select a shipping address to check shipping methods and requirements. On 2017/04/10 22:06:38, srahim wrote: > String edit from doc: "To see shipping methods and requirements, select an > address" > No period if it's a single sentence appearing by itself. Done. https://codereview.chromium.org/2812523004/diff/20001/components/payments_str... components/payments_strings.grdp:271: Can’t open payment app. On 2017/04/10 22:06:38, srahim wrote: > Minor nit: if this is a single sentence, and no other sentences appear with it, > remove period per Google style. Done.
The CQ bit was checked by gogerald@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by gogerald@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from srahim@chromium.org Link to the patchset: https://codereview.chromium.org/2812523004/#ps40001 (title: "address comments")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1491868543542970,
"parent_rev": "43a2ee9eef1c46635df943448eeeaa799b076843", "commit_rev":
"36b88dcdf796a4bd6b2442f11a44d453c54d7e65"}
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1491868543542970,
"parent_rev": "43a2ee9eef1c46635df943448eeeaa799b076843", "commit_rev":
"36b88dcdf796a4bd6b2442f11a44d453c54d7e65"}
Message was sent while issue was closed.
Description was changed from ========== update strings Update payments related strings according to this doc: https://docs.google.com/a/google.com/document/d/18sbGGysw9SSFHv_cYebZlK9uIbxd... BUG=710175 ========== to ========== update strings Update payments related strings according to this doc: https://docs.google.com/a/google.com/document/d/18sbGGysw9SSFHv_cYebZlK9uIbxd... BUG=710175 Review-Url: https://codereview.chromium.org/2812523004 Cr-Commit-Position: refs/heads/master@{#463462} Committed: https://chromium.googlesource.com/chromium/src/+/36b88dcdf796a4bd6b2442f11a44... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as https://chromium.googlesource.com/chromium/src/+/36b88dcdf796a4bd6b2442f11a44...
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:40001) has been created in https://codereview.chromium.org/2814623003/ by mkwst@chromium.org. The reason for reverting is: This broke some Android tests in https://uberchromegw.corp.google.com/i/chromium.linux/builders/Android%20Test... (I guess they have hard-coded strings?).
Message was sent while issue was closed.
Description was changed from ========== update strings Update payments related strings according to this doc: https://docs.google.com/a/google.com/document/d/18sbGGysw9SSFHv_cYebZlK9uIbxd... BUG=710175 Review-Url: https://codereview.chromium.org/2812523004 Cr-Commit-Position: refs/heads/master@{#463462} Committed: https://chromium.googlesource.com/chromium/src/+/36b88dcdf796a4bd6b2442f11a44... ========== to ========== update strings Update payments related strings according to this doc: https://docs.google.com/a/google.com/document/d/18sbGGysw9SSFHv_cYebZlK9uIbxd... BUG=710175 Review-Url: https://codereview.chromium.org/2812523004 Cr-Commit-Position: refs/heads/master@{#463462} Committed: https://chromium.googlesource.com/chromium/src/+/36b88dcdf796a4bd6b2442f11a44... ==========
The CQ bit was checked by gogerald@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Relanding after fixing tests
The CQ bit was checked by gogerald@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from srahim@chromium.org, rouslan@chromium.org Link to the patchset: https://codereview.chromium.org/2812523004/#ps60001 (title: "fix tests")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1491921318102930,
"parent_rev": "82382cca8c9aa804acb7fd9cfaa6e4478f92cd7d", "commit_rev":
"41de7075b5df44532a910a912d76550a32bad708"}
Message was sent while issue was closed.
Description was changed from ========== update strings Update payments related strings according to this doc: https://docs.google.com/a/google.com/document/d/18sbGGysw9SSFHv_cYebZlK9uIbxd... BUG=710175 Review-Url: https://codereview.chromium.org/2812523004 Cr-Commit-Position: refs/heads/master@{#463462} Committed: https://chromium.googlesource.com/chromium/src/+/36b88dcdf796a4bd6b2442f11a44... ========== to ========== update strings Update payments related strings according to this doc: https://docs.google.com/a/google.com/document/d/18sbGGysw9SSFHv_cYebZlK9uIbxd... BUG=710175 Review-Url: https://codereview.chromium.org/2812523004 Cr-Original-Commit-Position: refs/heads/master@{#463462} Committed: https://chromium.googlesource.com/chromium/src/+/36b88dcdf796a4bd6b2442f11a44... Review-Url: https://codereview.chromium.org/2812523004 Cr-Commit-Position: refs/heads/master@{#463625} Committed: https://chromium.googlesource.com/chromium/src/+/41de7075b5df44532a910a912d76... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:60001) as https://chromium.googlesource.com/chromium/src/+/41de7075b5df44532a910a912d76... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
