Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 2814493002: Require native before logging a histogram (Closed)

Created:
3 years, 8 months ago by David Trainor- moved to gerrit
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Require native before logging a histogram The download recovery code added a call to RecordHistogram.recordBooleanHistogram to help track when we hit the recovery path, but this can happen when the native library isn't loaded. Since we just want a rough idea of if this is happening, guard it by requiring native to be loaded before logging the result. BUG=699323 Review-Url: https://codereview.chromium.org/2804743002 Cr-Commit-Position: refs/heads/master@{#462140} (cherry picked from commit 60240a376d22f0951ee9dd063c4c297183a21122) Review-Url: https://codereview.chromium.org/2814493002 . Cr-Commit-Position: refs/branch-heads/3029@{#642} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/58f9ba38304ec8c47f2025d14bc6f5f6d5e4a507

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java View 3 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
David Trainor- moved to gerrit
3 years, 8 months ago (2017-04-10 15:43:57 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
58f9ba38304ec8c47f2025d14bc6f5f6d5e4a507.

Powered by Google App Engine
This is Rietveld 408576698