Require native before logging a histogram

Require native before logging a histogram

The download recovery code added a call to
RecordHistogram.recordBooleanHistogram to help track when we hit the
recovery path, but this can happen when the native library isn't loaded.
Since we just want a rough idea of if this is happening, guard it by
requiring native to be loaded before logging the result.

BUG=699323
Review-Url: https://codereview.chromium.org/2804743002
Cr-Commit-Position: refs/heads/master@{#462140}
Committed: https://chromium.googlesource.com/chromium/src/+/60240a376d22f0951ee9dd063c4c297183a21122

[David Trainor- moved to gerrit, 2017-04-05 16:22:13]

dtrainor@chromium.org changed reviewers:
+ tedchoc@chromium.org

[David Trainor- moved to gerrit, 2017-04-05 16:22:14]

ptal :/

[Ted C, 2017-04-05 16:26:18]

https://codereview.chromium.org/2804743002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java
(right):

https://codereview.chromium.org/2804743002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java:182:
if (LibraryLoader.isInitialized()) {
Use CachedMetrics here

[David Trainor- moved to gerrit, 2017-04-05 16:59:04]

On 2017/04/05 16:26:18, Ted C wrote:
>
https://codereview.chromium.org/2804743002/diff/1/chrome/android/java/src/org...
> File
>
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java
> (right):
> 
>
https://codereview.chromium.org/2804743002/diff/1/chrome/android/java/src/org...
>
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java:182:
> if (LibraryLoader.isInitialized()) {
> Use CachedMetrics here

CachedMetrics doesn't have a boolean histogram.  We could probably emulate it
with the other types, but I'd rather just be safe for the M58 beta cut.  I'm
fine landing a more comprehensive fix later this week.

[Ted C, 2017-04-05 16:59:57]

lgtm

[David Trainor- moved to gerrit, 2017-04-05 17:01:01]

The CQ bit was checked by dtrainor@chromium.org

[commit-bot: I haz the power, 2017-04-05 17:01:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-05 17:56:12]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1491411661602510,
"parent_rev": "e620ab8ad484d94fa90daf44802f9e99c2aaa65f", "commit_rev":
"60240a376d22f0951ee9dd063c4c297183a21122"}

[commit-bot: I haz the power, 2017-04-05 17:57:05]

Description was changed from

==========
Require native before logging a histogram

The download recovery code added a call to
RecordHistogram.recordBooleanHistogram to help track when we hit the
recovery path, but this can happen when the native library isn't loaded.
Since we just want a rough idea of if this is happening, guard it by
requiring native to be loaded before logging the result.

BUG=699323
==========

to

==========
Require native before logging a histogram

The download recovery code added a call to
RecordHistogram.recordBooleanHistogram to help track when we hit the
recovery path, but this can happen when the native library isn't loaded.
Since we just want a rough idea of if this is happening, guard it by
requiring native to be loaded before logging the result.

BUG=699323

Review-Url: https://codereview.chromium.org/2804743002
Cr-Commit-Position: refs/heads/master@{#462140}
Committed:
https://chromium.googlesource.com/chromium/src/+/60240a376d22f0951ee9dd063c4c...
==========

[commit-bot: I haz the power, 2017-04-05 17:57:06]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/60240a376d22f0951ee9dd063c4c...