Splitting up RenderWidgetHostLatencyTracker and some renames.

Splitting up RenderWidgetHostLatencyTracker and some renames.

This is in preparation for latency reporting in Mus - see CL https://codereview.chromium.org/2806163004.

- Splits out RWHLatencyTracker::OnGpuSwapBuffersCompleted(), moving it into a
  separate LatencyTracker class, which RWHLatencyTracker extends
- Renames INPUT_EVENT_BROWSER_RECEIVED_RENDERER_SWAP_COMPONENT to
  DISPLAY_COMPOSITOR_RECEIVED_FRAME_COMPONENT
- Renames SetLatencyInfo in PassThroughImageTransportSurface and
  CommandBufferProxyImpl to AddLatencyInfo.

TBR=tsepez@chromium.org
BUG=686865
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2814483002
Cr-Commit-Position: refs/heads/master@{#463464}
Committed: https://chromium.googlesource.com/chromium/src/+/598a769a9e1dc76058c61ccd0c9e2eb60ca776e5

[mfomitchev, 2017-04-10 15:21:57]

Description was changed from

==========
Splitting up RenderWidgetHostLatencyTracker and some renames.

BUG=686865
==========

to

==========
Splitting up RenderWidgetHostLatencyTracker and some renames.

BUG=686865
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[mfomitchev, 2017-04-10 15:22:00]

The CQ bit was checked by mfomitchev@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-10 15:22:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 15:25:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-10 15:25:16]

Dry run: Try jobs failed on following builders:
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[mfomitchev, 2017-04-10 15:38:44]

The CQ bit was checked by mfomitchev@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-10 15:39:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mfomitchev, 2017-04-10 15:59:22]

Description was changed from

==========
Splitting up RenderWidgetHostLatencyTracker and some renames.

BUG=686865
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Splitting up RenderWidgetHostLatencyTracker and some renames.

This is in preparation for latency reporting in Mus - see CL
https://codereview.chromium.org/2806163004.

- Splits out RWHLatencyTracker::OnGpuSwapBuffersCompleted(), moving it into a
separate LatencyTracker class, which RWHLatencyTracker extends
- Renames INPUT_EVENT_BROWSER_RECEIVED_RENDERER_SWAP_COMPONENT to
DISPLAY_COMPOSITOR_RECEIVED_FRAME_COMPONENT
- Renames SetLatencyInfo in PassThroughImageTransportSurface and
CommandBufferProxyImpl to AddLatencyInfo.

BUG=686865
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[mfomitchev, 2017-04-10 16:00:00]

mfomitchev@chromium.org changed reviewers:
+ tdresser@chromium.org

[tdresser, 2017-04-10 16:15:54]

Thanks for splitting this up.

Looks pretty good, just a couple high level questions.

https://codereview.chromium.org/2814483002/diff/20001/content/browser/rendere...
File content/browser/renderer_host/input/render_widget_host_latency_tracker.cc
(right):

https://codereview.chromium.org/2814483002/diff/20001/content/browser/rendere...
content/browser/renderer_host/input/render_widget_host_latency_tracker.cc:147:
void RenderWidgetHostLatencyTracker::ComputeInputLatencyHistograms(
How did you decide what things should move, and what things shouldn't?

https://codereview.chromium.org/2814483002/diff/20001/ui/latency/latency_trac...
File ui/latency/latency_tracker.h (right):

https://codereview.chromium.org/2814483002/diff/20001/ui/latency/latency_trac...
ui/latency/latency_tracker.h:8: #include <stdint.h>
Is this used?

https://codereview.chromium.org/2814483002/diff/20001/ui/latency/latency_trac...
ui/latency/latency_tracker.h:10: #include <vector>
Is this used?

https://codereview.chromium.org/2814483002/diff/20001/ui/latency/latency_trac...
ui/latency/latency_tracker.h:18: class LatencyTracker {
Should we split up the RenderWidgetHostLatencyTracker unit tests?

[commit-bot: I haz the power, 2017-04-10 16:50:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-10 16:50:03]

Dry run: This issue passed the CQ dry run.

[mfomitchev, 2017-04-10 19:00:07]

https://codereview.chromium.org/2814483002/diff/20001/content/browser/rendere...
File content/browser/renderer_host/input/render_widget_host_latency_tracker.cc
(right):

https://codereview.chromium.org/2814483002/diff/20001/content/browser/rendere...
content/browser/renderer_host/input/render_widget_host_latency_tracker.cc:147:
void RenderWidgetHostLatencyTracker::ComputeInputLatencyHistograms(
On 2017/04/10 16:15:54, tdresser wrote:
> How did you decide what things should move, and what things shouldn't?

OnGpuSwapBuffersCompleted is the only method that Mus GPU needs. It also happens
to be the method that is moved easiest because it does not need to rely on any
state. So I moved OnGpuSwapBuffersCompleted and all the helper methods it uses.

https://codereview.chromium.org/2814483002/diff/20001/ui/latency/latency_trac...
File ui/latency/latency_tracker.h (right):

https://codereview.chromium.org/2814483002/diff/20001/ui/latency/latency_trac...
ui/latency/latency_tracker.h:8: #include <stdint.h>
On 2017/04/10 16:15:54, tdresser wrote:
> Is this used?

Removed

https://codereview.chromium.org/2814483002/diff/20001/ui/latency/latency_trac...
ui/latency/latency_tracker.h:10: #include <vector>
On 2017/04/10 16:15:54, tdresser wrote:
> Is this used?

Removed

https://codereview.chromium.org/2814483002/diff/20001/ui/latency/latency_trac...
ui/latency/latency_tracker.h:18: class LatencyTracker {
On 2017/04/10 16:15:54, tdresser wrote:
> Should we split up the RenderWidgetHostLatencyTracker unit tests?

All the unit tests I see that test OnGpuSwapBuffersCompleted also use
OnInputEvent and OnInputEventAck, so they are not easily splittable. We could
create a test for OnGpuSwapBuffersCompleted and fake out
OnInputEvent/OnInputEventAck in OnGpuSwapBuffersCompleted, but will not real
give us more coverage, while is a non-trivial amount of work, so it doesn't seem
too useful to me.

[mfomitchev, 2017-04-10 19:18:04]

Description was changed from

==========
Splitting up RenderWidgetHostLatencyTracker and some renames.

This is in preparation for latency reporting in Mus - see CL
https://codereview.chromium.org/2806163004.

- Splits out RWHLatencyTracker::OnGpuSwapBuffersCompleted(), moving it into a
separate LatencyTracker class, which RWHLatencyTracker extends
- Renames INPUT_EVENT_BROWSER_RECEIVED_RENDERER_SWAP_COMPONENT to
DISPLAY_COMPOSITOR_RECEIVED_FRAME_COMPONENT
- Renames SetLatencyInfo in PassThroughImageTransportSurface and
CommandBufferProxyImpl to AddLatencyInfo.

BUG=686865
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Splitting up RenderWidgetHostLatencyTracker and some renames.

This is in preparation for latency reporting in Mus - see CL
https://codereview.chromium.org/2806163004.

- Splits out RWHLatencyTracker::OnGpuSwapBuffersCompleted(), moving it into a
  separate LatencyTracker class, which RWHLatencyTracker extends
- Renames INPUT_EVENT_BROWSER_RECEIVED_RENDERER_SWAP_COMPONENT to
  DISPLAY_COMPOSITOR_RECEIVED_FRAME_COMPONENT
- Renames SetLatencyInfo in PassThroughImageTransportSurface and
  CommandBufferProxyImpl to AddLatencyInfo.

BUG=686865
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[tdresser, 2017-04-10 20:26:56]

LGTM!

https://codereview.chromium.org/2814483002/diff/40001/ui/latency/latency_info.cc
File ui/latency/latency_info.cc (right):

https://codereview.chromium.org/2814483002/diff/40001/ui/latency/latency_info...
ui/latency/latency_info.cc:367: it++;
++it

[mfomitchev, 2017-04-10 21:18:07]

https://codereview.chromium.org/2814483002/diff/40001/ui/latency/latency_info.cc
File ui/latency/latency_info.cc (right):

https://codereview.chromium.org/2814483002/diff/40001/ui/latency/latency_info...
ui/latency/latency_info.cc:367: it++;
On 2017/04/10 20:26:56, tdresser wrote:
> ++it

Done.

[mfomitchev, 2017-04-10 21:20:55]

mfomitchev@chromium.org changed reviewers:
+ piman@chromium.org

[mfomitchev, 2017-04-10 21:20:56]

piman@chromium.org: Please review changes in 

gpu/ and content/browser/

[mfomitchev, 2017-04-10 21:22:11]

Description was changed from

==========
Splitting up RenderWidgetHostLatencyTracker and some renames.

This is in preparation for latency reporting in Mus - see CL
https://codereview.chromium.org/2806163004.

- Splits out RWHLatencyTracker::OnGpuSwapBuffersCompleted(), moving it into a
  separate LatencyTracker class, which RWHLatencyTracker extends
- Renames INPUT_EVENT_BROWSER_RECEIVED_RENDERER_SWAP_COMPONENT to
  DISPLAY_COMPOSITOR_RECEIVED_FRAME_COMPONENT
- Renames SetLatencyInfo in PassThroughImageTransportSurface and
  CommandBufferProxyImpl to AddLatencyInfo.

BUG=686865
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Splitting up RenderWidgetHostLatencyTracker and some renames.

This is in preparation for latency reporting in Mus - see CL
https://codereview.chromium.org/2806163004.

- Splits out RWHLatencyTracker::OnGpuSwapBuffersCompleted(), moving it into a
  separate LatencyTracker class, which RWHLatencyTracker extends
- Renames INPUT_EVENT_BROWSER_RECEIVED_RENDERER_SWAP_COMPONENT to
  DISPLAY_COMPOSITOR_RECEIVED_FRAME_COMPONENT
- Renames SetLatencyInfo in PassThroughImageTransportSurface and
  CommandBufferProxyImpl to AddLatencyInfo.

TBR=tsepez@chromium.org
BUG=686865

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[mfomitchev, 2017-04-10 21:24:31]

TBR tsepez@chromium.org for mechanical rename in ui/latency/mojo

[piman, 2017-04-10 22:29:14]

lgtm

[mfomitchev, 2017-04-10 22:31:29]

The CQ bit was checked by mfomitchev@chromium.org

[mfomitchev, 2017-04-10 22:31:29]

The patchset sent to the CQ was uploaded after l-g-t-m from
tdresser@chromium.org
Link to the patchset: https://codereview.chromium.org/2814483002/#ps80001
(title: "[Moving OnGpuSwapBuffersCompleted() back up.")

[commit-bot: I haz the power, 2017-04-10 22:32:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-11 00:30:36]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1491863489269770,
"parent_rev": "7e550b9dbb90d9b72e51778a937ee5b03ef7f98f", "commit_rev":
"598a769a9e1dc76058c61ccd0c9e2eb60ca776e5"}

[commit-bot: I haz the power, 2017-04-11 00:31:57]

Description was changed from

==========
Splitting up RenderWidgetHostLatencyTracker and some renames.

This is in preparation for latency reporting in Mus - see CL
https://codereview.chromium.org/2806163004.

- Splits out RWHLatencyTracker::OnGpuSwapBuffersCompleted(), moving it into a
  separate LatencyTracker class, which RWHLatencyTracker extends
- Renames INPUT_EVENT_BROWSER_RECEIVED_RENDERER_SWAP_COMPONENT to
  DISPLAY_COMPOSITOR_RECEIVED_FRAME_COMPONENT
- Renames SetLatencyInfo in PassThroughImageTransportSurface and
  CommandBufferProxyImpl to AddLatencyInfo.

TBR=tsepez@chromium.org
BUG=686865

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Splitting up RenderWidgetHostLatencyTracker and some renames.

This is in preparation for latency reporting in Mus - see CL
https://codereview.chromium.org/2806163004.

- Splits out RWHLatencyTracker::OnGpuSwapBuffersCompleted(), moving it into a
  separate LatencyTracker class, which RWHLatencyTracker extends
- Renames INPUT_EVENT_BROWSER_RECEIVED_RENDERER_SWAP_COMPONENT to
  DISPLAY_COMPOSITOR_RECEIVED_FRAME_COMPONENT
- Renames SetLatencyInfo in PassThroughImageTransportSurface and
  CommandBufferProxyImpl to AddLatencyInfo.

TBR=tsepez@chromium.org
BUG=686865

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2814483002
Cr-Commit-Position: refs/heads/master@{#463464}
Committed:
https://chromium.googlesource.com/chromium/src/+/598a769a9e1dc76058c61ccd0c9e...
==========

[commit-bot: I haz the power, 2017-04-11 00:31:58]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/598a769a9e1dc76058c61ccd0c9e...