Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issue 2814453004: Add a layout test for APNG (Closed)

Created:
3 years, 8 months ago by scroggo_chromium
Modified:
3 years, 8 months ago
Reviewers:
foolip
CC:
chromium-reviews, shans, rjwright, blink-reviews-animation_chromium.org, darktears, blink-reviews, Eric Willigers
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a web platform test for APNG While animated-png.html uses internals for selecting frames and verifying that we decode APNGs properly, this test confirms that a basic animation will work correctly, and can work in other browsers. - apng.png A simple APNG with two frames. The first frame is red, and displays for as short a time as possible (11 ms; anything less than that and Chromium increases the time), followed by a green frame. The image does not loop. The green frame matches green.png, which already exists - animated-png-timeout-ref.html Reference page showing the existing image (green.png). BUG=437662 Review-Url: https://codereview.chromium.org/2814453004 Cr-Commit-Position: refs/heads/master@{#464038} Committed: https://chromium.googlesource.com/chromium/src/+/08f24841310c677a67f79f89253d971820069da4

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove unnecessary styling #

Patch Set 3 : Small cleanups #

Patch Set 4 : WIP: Convert to a web-platform-test #

Patch Set 5 : Move tests into web platform tests folder #

Patch Set 6 : Move the images, and update src #

Total comments: 10

Patch Set 7 : Respond to comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/external/wpt/apng/animated-png-timeout.html View 1 2 3 4 5 6 1 chunk +11 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/apng/animated-png-timeout-ref.html View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/images/apng.png View 1 2 3 4 5 6 Binary file 0 comments Download

Messages

Total messages: 15 (5 generated)
foolip
https://codereview.chromium.org/2814453004/diff/1/third_party/WebKit/LayoutTests/images/animated-png-timeout.html File third_party/WebKit/LayoutTests/images/animated-png-timeout.html (right): https://codereview.chromium.org/2814453004/diff/1/third_party/WebKit/LayoutTests/images/animated-png-timeout.html#newcode5 third_party/WebKit/LayoutTests/images/animated-png-timeout.html:5: img { margin: 1px; } Is this needed, can't ...
3 years, 8 months ago (2017-04-11 04:19:03 UTC) #2
scroggo_chromium
Patch set 3 is my last one as a LayoutTest, and patch set 4 attempts ...
3 years, 8 months ago (2017-04-11 13:57:50 UTC) #3
foolip
On 2017/04/11 13:57:50, scroggo_chromium wrote: > Patch set 3 is my last one as a ...
3 years, 8 months ago (2017-04-11 14:18:44 UTC) #4
scroggo_chromium
On 2017/04/11 14:18:44, foolip_UTC7 wrote: > On 2017/04/11 13:57:50, scroggo_chromium wrote: > > Patch set ...
3 years, 8 months ago (2017-04-11 19:02:52 UTC) #5
foolip
On 2017/04/11 19:02:52, scroggo_chromium wrote: > On 2017/04/11 14:18:44, foolip_UTC7 wrote: > > I've asked ...
3 years, 8 months ago (2017-04-12 04:44:12 UTC) #6
foolip
Just some nits. https://codereview.chromium.org/2814453004/diff/100001/third_party/WebKit/LayoutTests/external/wpt/apng/animated-png-timeout-expected.html File third_party/WebKit/LayoutTests/external/wpt/apng/animated-png-timeout-expected.html (right): https://codereview.chromium.org/2814453004/diff/100001/third_party/WebKit/LayoutTests/external/wpt/apng/animated-png-timeout-expected.html#newcode3 third_party/WebKit/LayoutTests/external/wpt/apng/animated-png-timeout-expected.html:3: <title>APNG test: Second frame displays quickly, ...
3 years, 8 months ago (2017-04-12 04:55:20 UTC) #7
scroggo_chromium
On 2017/04/12 04:44:12, foolip_UTC7 wrote: > On 2017/04/11 19:02:52, scroggo_chromium wrote: > > On 2017/04/11 ...
3 years, 8 months ago (2017-04-12 14:04:12 UTC) #9
foolip
lgtm Yay, thanks!
3 years, 8 months ago (2017-04-12 14:34:22 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2814453004/120001
3 years, 8 months ago (2017-04-12 14:34:36 UTC) #12
commit-bot: I haz the power
3 years, 8 months ago (2017-04-12 15:44:09 UTC) #15
Message was sent while issue was closed.
Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/08f24841310c677a67f79f89253d...

Powered by Google App Engine
This is Rietveld 408576698