third_party/WebKit/LayoutTests/external/wpt/apng/animated-png-timeout.html - Issue 2814453004: Add a layout test for APNG

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/external/wpt/apng/animated-png-timeout.html

Issue 2814453004: Add a layout test for APNG (Closed)

Patch Set: Move the images, and update src Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/external/wpt/apng/animated-png-timeout-expected.html » ('j') | third_party/WebKit/LayoutTests/external/wpt/apng/animated-png-timeout-expected.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <html class="reftest-wait">

	2 <head>
	foolip 2017/04/12 04:55:20 It's OK, and some reviewers like me encourage, to It's OK, and some reviewers like me encourage, to remove bits of markup that aren't needed. Removing <head>, </head>, </body> and </html> from this test should be fine. (There is no <body>, it's now implied by the <img> element.) scroggo_chromium 2017/04/12 14:04:11 Done. Show quoted text On 2017/04/12 04:55:20, foolip_UTC7 wrote: > It's OK, and some reviewers like me encourage, to remove bits of markup that > aren't needed. Removing <head>, </head>, </body> and </html> from this test > should be fine. (There is no <body>, it's now implied by the <img> element.) Done.
	3 <title>APNG test: Second frame displays quickly, replacing red with green.</titl e>
	foolip 2017/04/12 04:55:20 uNit: Having "test" as part of the test descriptio uNit: Having "test" as part of the test description almost never adds anything, and here it can be dropped with no harm done. scroggo_chromium 2017/04/12 14:04:11 Done. Show quoted text On 2017/04/12 04:55:20, foolip_UTC7 wrote: > uNit: Having "test" as part of the test description almost never adds anything, > and here it can be dropped with no harm done. Done.
	4 </head>

	5 <link rel="match" href="animated-png-timeout-expected.html"/>
	foolip 2017/04/12 04:55:20 Because of this syntax the name can be anything, b Because of this syntax the name can be anything, but -expected.txt will not be exported and if -expected.html are, that's rather confusing I'd say. The naming pattern in web-platform-tests is usually -ref.html, so animated-png-timeout-ref.html scroggo_chromium 2017/04/12 14:04:11 Done. Show quoted text On 2017/04/12 04:55:20, foolip_UTC7 wrote: > Because of this syntax the name can be anything, but -expected.txt will not be > exported and if -expected.html are, that's rather confusing I'd say. The naming > pattern in web-platform-tests is usually -ref.html, so > animated-png-timeout-ref.html Done.
	6 <img src=../images/apng-test.png onload="loaded()"/>

	7 <script>

	8 function loaded() {

	9 setTimeout(function() {

	10 document.documentElement.classList.remove("reftest-wait");

	11 }, 1000);

	12 }

	13 </script>

	14 </body>

	15 </html>

OLD	NEW