Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issue 2814273006: Remove an unnecessary CachedMetadata copy in URLLoaderClientImpl (Closed)

Created:
3 years, 8 months ago by yhirano
Modified:
3 years, 8 months ago
Reviewers:
kinuko, dcheng, tzik
CC:
chromium-reviews, loading-reviews_chromium.org, jam, darin-cc_chromium.org, Randy Smith (Not in Mondays), mmenke
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove an unnecessary CachedMetadata copy in URLLoaderClientImpl BUG=711580 Review-Url: https://codereview.chromium.org/2814273006 Cr-Commit-Position: refs/heads/master@{#464685} Committed: https://chromium.googlesource.com/chromium/src/+/736905bd65b4d98dccea3849185b12867030b187

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -13 lines) Patch
M content/browser/loader/async_resource_handler.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/child/resource_dispatcher.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/child/resource_dispatcher.cc View 1 1 chunk +6 lines, -3 lines 0 comments Download
M content/child/url_loader_client_impl.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M content/common/resource_messages.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (12 generated)
yhirano
PTAL
3 years, 8 months ago (2017-04-14 04:31:57 UTC) #4
yhirano
+dcheng@ for resource_messages.h
3 years, 8 months ago (2017-04-14 04:47:48 UTC) #9
tzik
lgtm
3 years, 8 months ago (2017-04-14 04:58:08 UTC) #10
dcheng
lgtm
3 years, 8 months ago (2017-04-14 05:04:42 UTC) #11
kinuko
lgtm
3 years, 8 months ago (2017-04-14 05:34:51 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2814273006/20001
3 years, 8 months ago (2017-04-14 05:37:20 UTC) #16
commit-bot: I haz the power
3 years, 8 months ago (2017-04-14 06:10:28 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/736905bd65b4d98dccea3849185b...

Powered by Google App Engine
This is Rietveld 408576698