Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Side by Side Diff: content/browser/loader/async_resource_handler.cc

Issue 2814273006: Remove an unnecessary CachedMetadata copy in URLLoaderClientImpl (Closed)
Patch Set: fix Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | content/child/resource_dispatcher.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/loader/async_resource_handler.h" 5 #include "content/browser/loader/async_resource_handler.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/command_line.h" 10 #include "base/command_line.h"
(...skipping 196 matching lines...) Expand 10 before | Expand all | Expand 10 after
207 response->head.download_file_path); 207 response->head.download_file_path);
208 } 208 }
209 209
210 response->head.request_start = request()->creation_time(); 210 response->head.request_start = request()->creation_time();
211 response->head.response_start = TimeTicks::Now(); 211 response->head.response_start = TimeTicks::Now();
212 filter->Send( 212 filter->Send(
213 new ResourceMsg_ReceivedResponse(GetRequestID(), response->head)); 213 new ResourceMsg_ReceivedResponse(GetRequestID(), response->head));
214 sent_received_response_msg_ = true; 214 sent_received_response_msg_ = true;
215 215
216 if (request()->response_info().metadata.get()) { 216 if (request()->response_info().metadata.get()) {
217 std::vector<char> copy(request()->response_info().metadata->data(), 217 std::vector<uint8_t> copy(request()->response_info().metadata->data(),
218 request()->response_info().metadata->data() + 218 request()->response_info().metadata->data() +
219 request()->response_info().metadata->size()); 219 request()->response_info().metadata->size());
220 filter->Send(new ResourceMsg_ReceivedCachedMetadata(GetRequestID(), copy)); 220 filter->Send(new ResourceMsg_ReceivedCachedMetadata(GetRequestID(), copy));
221 } 221 }
222 222
223 controller->Resume(); 223 controller->Resume();
224 } 224 }
225 225
226 void AsyncResourceHandler::OnWillStart( 226 void AsyncResourceHandler::OnWillStart(
227 const GURL& url, 227 const GURL& url,
228 std::unique_ptr<ResourceController> controller) { 228 std::unique_ptr<ResourceController> controller) {
229 ResourceMessageFilter* filter = GetFilter(); 229 ResourceMessageFilter* filter = GetFilter();
(...skipping 257 matching lines...) Expand 10 before | Expand all | Expand 10 after
487 void AsyncResourceHandler::SendUploadProgress( 487 void AsyncResourceHandler::SendUploadProgress(
488 const net::UploadProgress& progress) { 488 const net::UploadProgress& progress) {
489 ResourceMessageFilter* filter = GetFilter(); 489 ResourceMessageFilter* filter = GetFilter();
490 if (!filter) 490 if (!filter)
491 return; 491 return;
492 filter->Send(new ResourceMsg_UploadProgress( 492 filter->Send(new ResourceMsg_UploadProgress(
493 GetRequestID(), progress.position(), progress.size())); 493 GetRequestID(), progress.position(), progress.size()));
494 } 494 }
495 495
496 } // namespace content 496 } // namespace content
OLDNEW
« no previous file with comments | « no previous file | content/child/resource_dispatcher.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698