Removes a couple more functions from WmWindow

Removes a couple more functions from WmWindow

I started removing GetChildByShellWindowId(), but left it in places
that would have resulted in lots of unnecessary back and forth between
aura::Window and WmWindow.

BUG=687656
TEST=covered by tests
R=msw@chromium.org

Review-Url: https://codereview.chromium.org/2814243002
Cr-Commit-Position: refs/heads/master@{#464211}
Committed: https://chromium.googlesource.com/chromium/src/+/e6f4a61a3902af614f0a1176fb31b4d8914d2339

[sky, 2017-04-12 21:31:11]

The CQ bit was checked by sky@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-12 21:33:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 22:02:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-12 22:02:45]

Dry run: This issue passed the CQ dry run.

[msw, 2017-04-12 22:12:50]

lgtm with nits

https://codereview.chromium.org/2814243002/diff/20001/ash/root_window_control...
File ash/root_window_controller.cc (right):

https://codereview.chromium.org/2814243002/diff/20001/ash/root_window_control...
ash/root_window_controller.cc:204: // TODO(sky): This should take an
aura::Window. http://crbug.com/671246.
nit: remove todo

https://codereview.chromium.org/2814243002/diff/20001/chrome/browser/ui/ash/a...
File chrome/browser/ui/ash/app_list/app_list_interactive_uitest.cc (right):

https://codereview.chromium.org/2814243002/diff/20001/chrome/browser/ui/ash/a...
chrome/browser/ui/ash/app_list/app_list_interactive_uitest.cc:29: aura::Window*
root_window = ash::WmWindow::Get(ash::wm::GetActiveWindow())
nit: avoid WmWindow roundabout here?

[sky, 2017-04-12 22:35:08]

https://codereview.chromium.org/2814243002/diff/20001/ash/root_window_control...
File ash/root_window_controller.cc (right):

https://codereview.chromium.org/2814243002/diff/20001/ash/root_window_control...
ash/root_window_controller.cc:204: // TODO(sky): This should take an
aura::Window. http://crbug.com/671246.
On 2017/04/12 22:12:50, msw wrote:
> nit: remove todo

Done.

https://codereview.chromium.org/2814243002/diff/20001/chrome/browser/ui/ash/a...
File chrome/browser/ui/ash/app_list/app_list_interactive_uitest.cc (right):

https://codereview.chromium.org/2814243002/diff/20001/chrome/browser/ui/ash/a...
chrome/browser/ui/ash/app_list/app_list_interactive_uitest.cc:29: aura::Window*
root_window = ash::WmWindow::Get(ash::wm::GetActiveWindow())
On 2017/04/12 22:12:50, msw wrote:
> nit: avoid WmWindow roundabout here?

Done.

[sky, 2017-04-12 22:35:22]

The CQ bit was checked by sky@chromium.org

[sky, 2017-04-12 22:35:23]

The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org
Link to the patchset: https://codereview.chromium.org/2814243002/#ps40001
(title: "feedback")

[commit-bot: I haz the power, 2017-04-12 22:36:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 23:52:23]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1492036522482820,
"parent_rev": "97a6fea550e9d2fcd81649cffbb0de8b4750af9a", "commit_rev":
"e6f4a61a3902af614f0a1176fb31b4d8914d2339"}

[commit-bot: I haz the power, 2017-04-12 23:53:15]

Description was changed from

==========
Removes a couple more functions from WmWindow

I started removing GetChildByShellWindowId(), but left it in places
that would have resulted in lots of unnecessary back and forth between
aura::Window and WmWindow.

BUG=687656
TEST=covered by tests
R=msw@chromium.org
==========

to

==========
Removes a couple more functions from WmWindow

I started removing GetChildByShellWindowId(), but left it in places
that would have resulted in lots of unnecessary back and forth between
aura::Window and WmWindow.

BUG=687656
TEST=covered by tests
R=msw@chromium.org

Review-Url: https://codereview.chromium.org/2814243002
Cr-Commit-Position: refs/heads/master@{#464211}
Committed:
https://chromium.googlesource.com/chromium/src/+/e6f4a61a3902af614f0a1176fb31...
==========

[commit-bot: I haz the power, 2017-04-12 23:53:16]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/e6f4a61a3902af614f0a1176fb31...