ash/wm/workspace/phantom_window_controller.cc - Issue 2814243002: Removes a couple more functions from WmWindow

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/wm/workspace/phantom_window_controller.cc

Issue 2814243002: Removes a couple more functions from WmWindow (Closed)

Patch Set: feedback Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ash/wm/workspace/phantom_window_controller.cc

diff --git a/ash/wm/workspace/phantom_window_controller.cc b/ash/wm/workspace/phantom_window_controller.cc

index 143d922987330d1edf0ea60c8f90c6aefd555d79..d334e9ca0e4a38912033afbebd95759b07a83d44 100644

--- a/ash/wm/workspace/phantom_window_controller.cc

+++ b/ash/wm/workspace/phantom_window_controller.cc

@@ -120,7 +120,7 @@ std::unique_ptr<views::Widget> PhantomWindowController::CreatePhantomWidget(

phantom_widget->SetVisibilityChangedAnimationsEnabled(false);

WmWindow* phantom_widget_window =

WmWindow::Get(phantom_widget->GetNativeWindow());

- phantom_widget_window->SetShellWindowId(kShellWindowId_PhantomWindow);

+ phantom_widget_window->aura_window()->set_id(kShellWindowId_PhantomWindow);

phantom_widget->SetBounds(bounds_in_screen);

// TODO(sky): I suspect this is never true, verify that.

if (phantom_widget_window->GetParent() == window_->GetParent()) {