Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2814073004:
Add SwiftShader fallback for blacklisted GPU test. (Closed)
DescriptionAdd test for SwiftShader fallback with blacklisted GPU.
BUG=swiftshader:32
TBR=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2814073004
Cr-Commit-Position: refs/heads/master@{#464406}
Committed: https://chromium.googlesource.com/chromium/src/+/c7fb077d3756a3293f090dbd0e7b594fd18e6a75
Patch Set 1 #
Total comments: 1
Messages
Total messages: 16 (11 generated)
The CQ bit was checked by capn@chromium.org to run a CQ dry run
capn@chromium.org changed reviewers: + kbr@chromium.org
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_optional_gpu_tests_rel on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_optional_gpu_...)
Description was changed from ========== Add SwiftShader fallback for blacklisted GPU test. BUG=swiftshader:32 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Add SwiftShader fallback for blacklisted GPU test. BUG=swiftshader:32 TBR=kbr@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
capn@chromium.org changed reviewers: + sugoi@chromium.org
PTAL
Description was changed from ========== Add SwiftShader fallback for blacklisted GPU test. BUG=swiftshader:32 TBR=kbr@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Add test for SwiftShader fallback with blacklisted GPU. BUG=swiftshader:32 TBR=kbr@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
On 2017/04/13 11:06:45, capn wrote: > PTAL LGTM
The CQ bit was checked by capn@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1492094936623460, "parent_rev":
"56d2fdda34f895208a7cc0156c53161bb660320e", "commit_rev":
"c7fb077d3756a3293f090dbd0e7b594fd18e6a75"}
Message was sent while issue was closed.
Description was changed from ========== Add test for SwiftShader fallback with blacklisted GPU. BUG=swiftshader:32 TBR=kbr@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Add test for SwiftShader fallback with blacklisted GPU. BUG=swiftshader:32 TBR=kbr@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2814073004 Cr-Commit-Position: refs/heads/master@{#464406} Committed: https://chromium.googlesource.com/chromium/src/+/c7fb077d3756a3293f090dbd0e7b... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/c7fb077d3756a3293f090dbd0e7b...
Message was sent while issue was closed.
https://codereview.chromium.org/2814073004/diff/1/content/test/gpu/gpu_tests/... File content/test/gpu/gpu_tests/gpu_process_integration_test.py (right): https://codereview.chromium.org/2814073004/diff/1/content/test/gpu/gpu_tests/... content/test/gpu/gpu_tests/gpu_process_integration_test.py:545: '--gpu-testing-device-id=0x27A2'], We should start adding some fake entries to the software_rendering_list.json and gpu_driver_bug_workaround_list.json so that we aren't continually chasing real entries in these files which might ultimately be changed. See http://crbug.com/701887 . |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
