Add SwiftShader fallback for blacklisted GPU test.

content/test/gpu/gpu_tests/gpu_process_integration_test.py

 # Copyright 2017 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import logging
 import os
 import sys
 
 from gpu_tests import gpu_integration_test
 from gpu_tests import gpu_process_expectations
@@ skipping 281 matching lines @@
     options = self.__class__._original_finder_options.browser_options
     if options.browser_type.startswith('android'):
       # Android doesn't support starting up the browser without any
       # GPU process. This test is skipped on Android in
       # gpu_process_expectations.py, but we must at least be able to
       # bring up the browser in order to detect that the test
       # shouldn't run. Faking a vendor and device ID can get the
       # browser into a state where it won't launch.
       return
     elif sys.platform in ('cygwin', 'win32'):
-      # Hit id 34 from kSoftwareRenderingListJson.
+      # Hit id 34 from kSoftwareRenderingListEntries.
       self.RestartBrowserIfNecessaryWithArgs([
         '--gpu-testing-vendor-id=0x5333',
         '--gpu-testing-device-id=0x8811'])
     elif sys.platform.startswith('linux'):
-      # Hit id 50 from kSoftwareRenderingListJson.
+      # Hit id 50 from kSoftwareRenderingListEntries.
       self.RestartBrowserIfNecessaryWithArgs([
         '--gpu-no-complete-info-collection',
         '--gpu-testing-vendor-id=0x10de',
         '--gpu-testing-device-id=0x0de1',
         '--gpu-testing-gl-vendor=VMware',
         '--gpu-testing-gl-renderer=softpipe',
         '--gpu-testing-gl-version="2.1 Mesa 10.1"'])
     elif sys.platform == 'darwin':
-      # Hit id 112 from kSoftwareRenderingListJson.
+      # Hit id 112 from kSoftwareRenderingListEntries.
       self.RestartBrowserIfNecessaryWithArgs([
         '--gpu-testing-vendor-id=0x8086',
         '--gpu-testing-device-id=0x0116'])
     self._Navigate(test_path)
     if self.tab.EvaluateJavaScript('chrome.gpuBenchmarking.hasGpuProcess()'):
       self.fail('GPU process detected')
 
   def _GpuProcess_driver_bug_workarounds_in_gpu_process(self, test_path):
     self.RestartBrowserIfNecessaryWithArgs([
       '--use_gpu_driver_workaround_for_testing'])
     self._Navigate(test_path)
     self._ValidateDriverBugWorkarounds(
       'use_gpu_driver_workaround_for_testing', None)
 
   def _GpuProcess_readback_webgl_gpu_process(self, test_path):
     # This test was designed to only run on desktop Linux.
     options = self.__class__._original_finder_options.browser_options
     is_platform_android = options.browser_type.startswith('android')
     if sys.platform.startswith('linux') and not is_platform_android:
-      # Hit id 110 from kSoftwareRenderingListJson.
+      # Hit id 110 from kSoftwareRenderingListEntries.
       self.RestartBrowserIfNecessaryWithArgs([
         '--gpu-testing-vendor-id=0x10de',
         '--gpu-testing-device-id=0x0de1',
         '--gpu-testing-gl-vendor=VMware',
         '--gpu-testing-gl-renderer=Gallium 0.4 ' \
         'on llvmpipe (LLVM 3.4, 256 bits)',
         '--gpu-testing-gl-version="3.0 Mesa 11.2"'])
       self._Navigate(test_path)
       feature_status_list = self.tab.EvaluateJavaScript(
           'browserBridge.gpuInfo.featureStatus.featureStatus')
       result = True
       for name, status in feature_status_list.items():
         if name == 'multiple_raster_threads':
           result = result and status == 'enabled_on'
         elif name == 'native_gpu_memory_buffers':
           result = result and status == 'disabled_software'
         elif name == 'webgl':
           result = result and status == 'enabled_readback'
         elif name == 'webgl2':
           result = result and status == 'unavailable_off'
         else:
           result = result and status == 'unavailable_software'
       if not result:
         self.fail('WebGL readback setup failed: %s' % feature_status_list)
 
   def _GpuProcess_driver_bug_workarounds_upon_gl_renderer(self, test_path):
     is_platform_android = self._RunningOnAndroid()
     if is_platform_android:
-      # Hit id 108 from kGpuDriverBugListJson.
+      # Hit id 108 from kGpuDriverBugListEntries.
       self.RestartBrowserIfNecessaryWithArgs([
         '--gpu-testing-gl-vendor=NVIDIA Corporation',
         '--gpu-testing-gl-renderer=NVIDIA Tegra',
         '--gpu-testing-gl-version=OpenGL ES 3.1 NVIDIA 343.00'])
     elif sys.platform in ('cygwin', 'win32'):
-      # Hit id 51 and 87 from kGpuDriverBugListJson.
+      # Hit id 51 and 87 from kGpuDriverBugListEntries.
       self.RestartBrowserIfNecessaryWithArgs([
         '--gpu-testing-vendor-id=0x1002',
         '--gpu-testing-device-id=0x6779',
         '--gpu-testing-driver-date=11-20-2014',
         '--gpu-testing-gl-vendor=Google Inc.',
         '--gpu-testing-gl-renderer=ANGLE ' \
         '(AMD Radeon HD 6450 Direct3D11 vs_5_0 ps_5_0)',
         '--gpu-testing-gl-version=OpenGL ES 2.0 (ANGLE 2.1.0.0c0d8006a9dd)'])
     elif sys.platform.startswith('linux'):
-      # Hit id 40 from kGpuDriverBugListJson.
+      # Hit id 40 from kGpuDriverBugListEntries.
       self.RestartBrowserIfNecessaryWithArgs([
         '--gpu-testing-vendor-id=0x0101',
         '--gpu-testing-device-id=0x0102',
         '--gpu-testing-gl-vendor=ARM',
         '--gpu-testing-gl-renderer=Mali-400 MP'])
     elif sys.platform == 'darwin':
       # Currently on osx no workaround relies on gl-renderer.
       return
     self._Navigate(test_path)
     if is_platform_android:
@@ skipping 15 matching lines @@
     self._VerifyGpuProcessPresent()
     recorded_workarounds, recorded_disabled_gl_extensions = (
       self._CompareAndCaptureDriverBugWorkarounds())
     # Add the testing workaround to the recorded workarounds.
     recorded_workarounds.append('use_gpu_driver_workaround_for_testing')
     # Relaunch the browser with OS-specific command line arguments.
     browser_args = ['--use_gpu_driver_workaround_for_testing',
                     '--disable-gpu-driver-bug-workarounds']
     # Inject some info to make sure the flags above are effective.
     if sys.platform == 'darwin':
-      # Hit id 33 from kGpuDriverBugListJson.
+      # Hit id 33 from kGpuDriverBugListEntries.
       browser_args.extend(['--gpu-testing-gl-vendor=Imagination'])
     else:
-      # Hit id 5 from kGpuDriverBugListJson.
+      # Hit id 5 from kGpuDriverBugListEntries.
       browser_args.extend(['--gpu-testing-vendor-id=0x10de',
                            '--gpu-testing-device-id=0x0001'])
       # no multi gpu on Android.
       if not self._RunningOnAndroid():
         browser_args.extend(['--gpu-testing-secondary-vendor-ids=',
                              '--gpu-testing-secondary-device-ids='])
     for workaround in recorded_workarounds:
       browser_args.append('--' + workaround)
     browser_args.append('--disable-gl-extensions=' +
                         recorded_disabled_gl_extensions)
@@ skipping 80 matching lines @@
       '--gpu-testing-secondary-vendor-ids=',
       '--gpu-testing-secondary-device-ids=',
       '--gpu-testing-gl-vendor=nouveau',
       '--disable-software-rasterizer'])
     self._Navigate(test_path)
     self._VerifyActiveAndInactiveGPUs(
       ['VENDOR = 0x10de, DEVICE= 0x0de1 *ACTIVE*'],
       [])
 
   def _GpuProcess_disabling_workarounds_works(self, test_path):
-    # Hit exception from id 215 from kGpuDriverBugListJson.
+    # Hit exception from id 215 from kGpuDriverBugListEntries.
     self.RestartBrowserIfNecessaryWithArgs([
       '--gpu-testing-vendor-id=0xbad9',
       '--gpu-testing-device-id=0xbad9',
       '--gpu-testing-secondary-vendor-ids=',
       '--gpu-testing-secondary-device-ids=',
       '--gpu-testing-gl-vendor=FakeVendor',
       '--gpu-testing-gl-renderer=FakeRenderer',
       '--use_gpu_driver_workaround_for_testing=0'])
     self._Navigate(test_path)
     workarounds, _ = (
       self._CompareAndCaptureDriverBugWorkarounds())
     if 'use_gpu_driver_workaround_for_testing' in workarounds:
       self.fail('use_gpu_driver_workaround_for_testing erroneously present')
 
   def _GpuProcess_swiftshader_for_webgl(self, test_path):
     # This test loads functional_webgl.html so that there is a
     # deliberate attempt to use an API which would start the GPU
     # process. On Windows, and eventually on other platforms where
     # SwiftShader is used, this test should pass.
     #
-    # TODO(kbr): figure out a better way than --disable-gpu to
-    # reliably trigger SwiftShader.
-    self.RestartBrowserIfNecessaryWithArgs(['--disable-gpu'])
-    self._NavigateAndWait(test_path)
-    # It looks like when SwiftShader is in use (via --disable-gpu),
-    # that GPU information collection doesn't yet contain what's
-    # expected (the system_info.gpu.aux_attributes['gl_renderer']
-    # looks like it'll be null). Verified locally that we can fetch
-    # the desired information via WebGL.
-    renderer = self.tab.EvaluateJavaScript('gl_renderer')
-    if not renderer:
-      self.fail('getParameter(UNMASKED_RENDERER_WEBGL) was null')
-    if 'SwiftShader' not in renderer:
-      self.fail('Expected SwiftShader renderer; instead got ' + renderer)
-    if not self.browser.supports_system_info:
-      self.fail("Browser doesn't support GetSystemInfo")
-    gpu = self.browser.GetSystemInfo().gpu
-    if not gpu:
-      self.fail('Target machine must have a GPU')
-    if not gpu.aux_attributes:
-      self.fail('Browser must support GPU aux attributes')
-    if not gpu.aux_attributes['software_rendering']:
-      self.fail("Software rendering was disabled")
-    device = gpu.devices[0]
-    if not device:
-      self.fail("System Info doesn't have a device")
+    args_list = ([
+      # Hit id 4 from kSoftwareRenderingListEntries.
+      '--gpu-testing-vendor-id=0x8086',
+      '--gpu-testing-device-id=0x27A2'],

[Ken Russell (switch to Gerrit), 2017/04/14 22:11:07]

We should start adding some fake entries to the software_rendering_list.json and
gpu_driver_bug_workaround_list.json so that we aren't continually chasing real
entries in these files which might ultimately be changed. See
http://crbug.com/701887 .

+      # Explicitly disable GPU access.
+     ['--disable-gpu'])
+    for args in args_list:
+      self.RestartBrowserIfNecessaryWithArgs(args)
+      self._NavigateAndWait(test_path)
+      # Validate the WebGL unmasked renderer string.
+      renderer = self.tab.EvaluateJavaScript('gl_renderer')
+      if not renderer:
+        self.fail('getParameter(UNMASKED_RENDERER_WEBGL) was null')
+      if 'SwiftShader' not in renderer:
+        self.fail('Expected SwiftShader renderer; instead got ' + renderer)
+      # Validate GPU info.
+      if not self.browser.supports_system_info:
+        self.fail("Browser doesn't support GetSystemInfo")
+      gpu = self.browser.GetSystemInfo().gpu
+      if not gpu:
+        self.fail('Target machine must have a GPU')
+      if not gpu.aux_attributes:
+        self.fail('Browser must support GPU aux attributes')
+      if not gpu.aux_attributes['software_rendering']:
+        self.fail("Software rendering was disabled")
+      if 'SwiftShader' not in gpu.aux_attributes['gl_renderer']:
+        self.fail("Expected 'SwiftShader' in GPU info GL renderer string")
+      if 'Google' not in gpu.aux_attributes['gl_vendor']:
+        self.fail("Expected 'Google' in GPU info GL vendor string")
+      device = gpu.devices[0]
+      if not device:
+        self.fail("System Info doesn't have a device")
 
 def load_tests(loader, tests, pattern):
   del loader, tests, pattern  # Unused.
   return gpu_integration_test.LoadAllTestsInModule(sys.modules[__name__])