Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2821233003:
Set string-prototype-properties to NeedsManualRebaseline (Closed)
DescriptionSet string-prototype-properties to NeedsManualRebaseline
BUG=v8:6206
Review-Url: https://codereview.chromium.org/2821233003
Cr-Commit-Position: refs/heads/master@{#465522}
Committed: https://chromium.googlesource.com/chromium/src/+/78ebe25358d697d71bd3ae61538d3a6c9bb04fb7
Patch Set 1 #Patch Set 2 : NeedsManualRebaseline #Messages
Total messages: 22 (13 generated)
The CQ bit was checked by jgruber@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
jgruber@chromium.org changed reviewers: + littledan@chromium.org, yangguo@chromium.org
jgruber@chromium.org changed reviewers: + marja@chromium.org
rubberstamp lgtm
The CQ bit was unchecked by jgruber@chromium.org
The CQ bit was checked by jgruber@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1492519772180430, "parent_rev":
"56a91683c888f0522c6fa23748c384cc21f4ed21", "commit_rev":
"5df0d26974915cf449e247e0d5d77ba126212c9d"}
Message was sent while issue was closed.
Description was changed from ========== Set string-prototype-properties to NeedsRebaseline BUG=v8:6206 ========== to ========== Set string-prototype-properties to NeedsRebaseline BUG=v8:6206 Review-Url: https://codereview.chromium.org/2821233003 Cr-Commit-Position: refs/heads/master@{#465212} Committed: https://chromium.googlesource.com/chromium/src/+/5df0d26974915cf449e247e0d5d7... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/5df0d26974915cf449e247e0d5d7...
Message was sent while issue was closed.
See https://github.com/v8/v8/wiki/Blink-layout-tests - you can't just set needsrebaseline.
Message was sent while issue was closed.
Description was changed from ========== Set string-prototype-properties to NeedsRebaseline BUG=v8:6206 Review-Url: https://codereview.chromium.org/2821233003 Cr-Commit-Position: refs/heads/master@{#465212} Committed: https://chromium.googlesource.com/chromium/src/+/5df0d26974915cf449e247e0d5d7... ========== to ========== Set string-prototype-properties to NeedsManualRebaseline BUG=v8:6206 ==========
On 2017/04/18 19:21:35, Michael Achenbach wrote: > See https://github.com/v8/v8/wiki/Blink-layout-tests - you can't just set > needsrebaseline. Right... Fixed to NeedsManualRebaseline and relanding.
The CQ bit was checked by jgruber@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from marja@chromium.org Link to the patchset: https://codereview.chromium.org/2821233003/#ps20001 (title: "NeedsManualRebaseline")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492584661894930,
"parent_rev": "132ccede61f0fe6fe34617a73eb945eb99ef1bee", "commit_rev":
"78ebe25358d697d71bd3ae61538d3a6c9bb04fb7"}
Message was sent while issue was closed.
Description was changed from ========== Set string-prototype-properties to NeedsManualRebaseline BUG=v8:6206 ========== to ========== Set string-prototype-properties to NeedsManualRebaseline BUG=v8:6206 Review-Url: https://codereview.chromium.org/2821233003 Cr-Commit-Position: refs/heads/master@{#465522} Committed: https://chromium.googlesource.com/chromium/src/+/78ebe25358d697d71bd3ae61538d... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/78ebe25358d697d71bd3ae61538d... |
