Reland - [DeviceService] Add service tests for VibrationManager.

Reland - [DeviceService] Add service tests for VibrationManager.

Original CL was reverted because it appears to have broken
service_unittests on Nexus 5X.
This CL fixes it and relands.

VibrationManagerImpl.java is in //device/vibration while the
VibrationManagerImplTest.java is still in //content,
to be able to hide all //device/vibration impl inside Device Service,
we must eliminate this concrete dependency on //device/vibration from
content layer.

As VibrationManagerImplTest.java is an integration test based on
content shell test infra, we can't move it outside of //content.
So we consider to use other tests to replace it, while the renderer-side
testing has already been covered by layout tests created at
https://codereview.chromium.org/2731953003/, so we create this CL to
cover the VibrationManager interface impl testing:
 - creates an infra for Device Service service tests.
 - adds a new service test for VibrationManager interface.

Then after this CL we'll be able to hide all vibration impl inside
Device Service with a follow-up CL.

BUG=689379
TEST=service_unittests
TBR=avi@chromium.org

Review-Url: https://codereview.chromium.org/2774783003
Cr-Original-Commit-Position: refs/heads/master@{#463612}
Committed: https://chromium.googlesource.com/chromium/src/+/9c17bee62f1e16224fabb7c83bbeaab719015761
Review-Url: https://codereview.chromium.org/2814013002
Cr-Commit-Position: refs/heads/master@{#463915}
Committed: https://chromium.googlesource.com/chromium/src/+/70adfd46aefb86021a640567bdc07d6b6c73a066

[leonhsl(Using Gerrit), 2017-04-11 23:46:52]

Patchset #2 (id:20001) has been deleted

[leonhsl(Using Gerrit), 2017-04-11 23:49:11]

Description was changed from

==========
Reland - [DeviceService] Add service tests for VibrationManager.

Original CL was reverted because it appears to have broken
service_unittests on Nexus 5X.
This CL fixes it and relands.

VibrationManagerImpl.java is in //device/vibration while the
VibrationManagerImplTest.java is still in //content,
to be able to hide all //device/vibration impl inside Device Service,
we must eliminate this concrete dependency on //device/vibration from
content layer.

As VibrationManagerImplTest.java is an integration test based on
content shell test infra, we can't move it outside of //content.
So we consider to use other tests to replace it, while the renderer-side
testing has already been covered by layout tests created at
https://codereview.chromium.org/2731953003/, so we create this CL to
cover the VibrationManager interface impl testing:
 - creates an infra for Device Service service tests.
 - adds a new service test for VibrationManager interface.

Then after this CL we'll be able to hide all vibration impl inside
Device Service with a follow-up CL.

BUG=689379
TEST=service_unittests

Review-Url: https://codereview.chromium.org/2774783003
Cr-Commit-Position: refs/heads/master@{#463612}
Committed:
https://chromium.googlesource.com/chromium/src/+/9c17bee62f1e16224fabb7c83bbe...

Improve tests for Mixed-Case JIDs.

1. FakeAuthenticator now verifies that correct IDs are passed on both
ends of the connection.
2. All tests in JingleSessionTest now use mixed-case JIDs.

BUG=707833

Review-Url: https://codereview.chromium.org/2808283002
Cr-Commit-Position: refs/heads/master@{#463833}
==========

to

==========
Reland - [DeviceService] Add service tests for VibrationManager.

Original CL was reverted because it appears to have broken
service_unittests on Nexus 5X.
This CL fixes it and relands.

VibrationManagerImpl.java is in //device/vibration while the
VibrationManagerImplTest.java is still in //content,
to be able to hide all //device/vibration impl inside Device Service,
we must eliminate this concrete dependency on //device/vibration from
content layer.

As VibrationManagerImplTest.java is an integration test based on
content shell test infra, we can't move it outside of //content.
So we consider to use other tests to replace it, while the renderer-side
testing has already been covered by layout tests created at
https://codereview.chromium.org/2731953003/, so we create this CL to
cover the VibrationManager interface impl testing:
 - creates an infra for Device Service service tests.
 - adds a new service test for VibrationManager interface.

Then after this CL we'll be able to hide all vibration impl inside
Device Service with a follow-up CL.

BUG=689379
TEST=service_unittests

Review-Url: https://codereview.chromium.org/2774783003
Cr-Commit-Position: refs/heads/master@{#463612}
Committed:
https://chromium.googlesource.com/chromium/src/+/9c17bee62f1e16224fabb7c83bbe...
==========

[leonhsl(Using Gerrit), 2017-04-11 23:49:51]

The CQ bit was checked by leon.han@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-11 23:50:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[leonhsl(Using Gerrit), 2017-04-11 23:54:03]

Patchset #1 (id:1) has been deleted

[leonhsl(Using Gerrit), 2017-04-12 00:02:05]

The CQ bit was checked by leon.han@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-12 00:03:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 00:28:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-12 00:28:54]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[leonhsl(Using Gerrit), 2017-04-12 01:49:57]

The CQ bit was checked by leon.han@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-12 01:50:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[leonhsl(Using Gerrit), 2017-04-12 01:51:42]

The CQ bit was checked by leon.han@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-12 01:52:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[leonhsl(Using Gerrit), 2017-04-12 01:52:38]

Patchset #2 (id:60001) has been deleted

[leonhsl(Using Gerrit), 2017-04-12 02:51:31]

leon.han@intel.com changed reviewers:
+ rockot@chromium.org

[leonhsl(Using Gerrit), 2017-04-12 02:51:32]

Hi, Ken, seems a C++ source_set target stops the propagation of a java target,
so original CL failed on android_n5x_swarming_rel bot.
    # Although ps#1 dry-run looks like all green, if you open
android_n5x_swarming_rel bot report it displays that service_unittests is red!
Maybe a bug..
    # ps#2 android_n5x_swarming_rel is real green.

[commit-bot: I haz the power, 2017-04-12 02:55:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-12 02:55:52]

Dry run: This issue passed the CQ dry run.

[Ken Rockot(use gerrit already), 2017-04-12 02:57:14]

OK - LGTM for now, as unfortunate as that is. Thanks!

[leonhsl(Using Gerrit), 2017-04-12 03:00:21]

Description was changed from

==========
Reland - [DeviceService] Add service tests for VibrationManager.

Original CL was reverted because it appears to have broken
service_unittests on Nexus 5X.
This CL fixes it and relands.

VibrationManagerImpl.java is in //device/vibration while the
VibrationManagerImplTest.java is still in //content,
to be able to hide all //device/vibration impl inside Device Service,
we must eliminate this concrete dependency on //device/vibration from
content layer.

As VibrationManagerImplTest.java is an integration test based on
content shell test infra, we can't move it outside of //content.
So we consider to use other tests to replace it, while the renderer-side
testing has already been covered by layout tests created at
https://codereview.chromium.org/2731953003/, so we create this CL to
cover the VibrationManager interface impl testing:
 - creates an infra for Device Service service tests.
 - adds a new service test for VibrationManager interface.

Then after this CL we'll be able to hide all vibration impl inside
Device Service with a follow-up CL.

BUG=689379
TEST=service_unittests

Review-Url: https://codereview.chromium.org/2774783003
Cr-Commit-Position: refs/heads/master@{#463612}
Committed:
https://chromium.googlesource.com/chromium/src/+/9c17bee62f1e16224fabb7c83bbe...
==========

to

==========
Reland - [DeviceService] Add service tests for VibrationManager.

Original CL was reverted because it appears to have broken
service_unittests on Nexus 5X.
This CL fixes it and relands.

VibrationManagerImpl.java is in //device/vibration while the
VibrationManagerImplTest.java is still in //content,
to be able to hide all //device/vibration impl inside Device Service,
we must eliminate this concrete dependency on //device/vibration from
content layer.

As VibrationManagerImplTest.java is an integration test based on
content shell test infra, we can't move it outside of //content.
So we consider to use other tests to replace it, while the renderer-side
testing has already been covered by layout tests created at
https://codereview.chromium.org/2731953003/, so we create this CL to
cover the VibrationManager interface impl testing:
 - creates an infra for Device Service service tests.
 - adds a new service test for VibrationManager interface.

Then after this CL we'll be able to hide all vibration impl inside
Device Service with a follow-up CL.

BUG=689379
TEST=service_unittests
TBR=avi@chromium.org

Review-Url: https://codereview.chromium.org/2774783003
Cr-Commit-Position: refs/heads/master@{#463612}
Committed:
https://chromium.googlesource.com/chromium/src/+/9c17bee62f1e16224fabb7c83bbe...
==========

[leonhsl(Using Gerrit), 2017-04-12 03:02:12]

leon.han@intel.com changed reviewers:
+ avi@chromium.org

[leonhsl(Using Gerrit), 2017-04-12 03:02:12]

Thanks Ken a lot! Let me TBR Avi for //content/ changes he approved in original
CL, send to CQ now.

[leonhsl(Using Gerrit), 2017-04-12 03:05:03]

On 2017/04/12 03:02:12, leonhsl wrote:
> Thanks Ken a lot! Let me TBR Avi for //content/ changes he approved in
original
> CL, send to CQ now.

Oops, seems I closed this CL incidentally... Will upload a new one to land.

[Ken Rockot(use gerrit already), 2017-04-12 03:06:27]

On 2017/04/12 at 03:05:03, leon.han wrote:
> On 2017/04/12 03:02:12, leonhsl wrote:
> > Thanks Ken a lot! Let me TBR Avi for //content/ changes he approved in
original
> > CL, send to CQ now.
> 
> Oops, seems I closed this CL incidentally... Will upload a new one to land.

We can just reopen it

[Ken Rockot(use gerrit already), 2017-04-12 03:06:48]

(Done)

On Tue, Apr 11, 2017 at 8:06 PM, <rockot@chromium.org> wrote:

> On 2017/04/12 at 03:05:03, leon.han wrote:
> > On 2017/04/12 03:02:12, leonhsl wrote:
> > > Thanks Ken a lot! Let me TBR Avi for //content/ changes he approved in
> original
> > > CL, send to CQ now.
> >
> > Oops, seems I closed this CL incidentally... Will upload a new one to
> land.
>
> We can just reopen it
>
> https://codereview.chromium.org/2814013002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[leonhsl(Using Gerrit), 2017-04-12 03:09:47]

The CQ bit was checked by leon.han@intel.com

[commit-bot: I haz the power, 2017-04-12 03:10:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 03:14:16]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1491966587413880,
"parent_rev": "9589ae21cd500f7e62833fd54392127902a7d004", "commit_rev":
"70adfd46aefb86021a640567bdc07d6b6c73a066"}

[commit-bot: I haz the power, 2017-04-12 03:15:10]

Description was changed from

==========
Reland - [DeviceService] Add service tests for VibrationManager.

Original CL was reverted because it appears to have broken
service_unittests on Nexus 5X.
This CL fixes it and relands.

VibrationManagerImpl.java is in //device/vibration while the
VibrationManagerImplTest.java is still in //content,
to be able to hide all //device/vibration impl inside Device Service,
we must eliminate this concrete dependency on //device/vibration from
content layer.

As VibrationManagerImplTest.java is an integration test based on
content shell test infra, we can't move it outside of //content.
So we consider to use other tests to replace it, while the renderer-side
testing has already been covered by layout tests created at
https://codereview.chromium.org/2731953003/, so we create this CL to
cover the VibrationManager interface impl testing:
 - creates an infra for Device Service service tests.
 - adds a new service test for VibrationManager interface.

Then after this CL we'll be able to hide all vibration impl inside
Device Service with a follow-up CL.

BUG=689379
TEST=service_unittests
TBR=avi@chromium.org

Review-Url: https://codereview.chromium.org/2774783003
Cr-Commit-Position: refs/heads/master@{#463612}
Committed:
https://chromium.googlesource.com/chromium/src/+/9c17bee62f1e16224fabb7c83bbe...
==========

to

==========
Reland - [DeviceService] Add service tests for VibrationManager.

Original CL was reverted because it appears to have broken
service_unittests on Nexus 5X.
This CL fixes it and relands.

VibrationManagerImpl.java is in //device/vibration while the
VibrationManagerImplTest.java is still in //content,
to be able to hide all //device/vibration impl inside Device Service,
we must eliminate this concrete dependency on //device/vibration from
content layer.

As VibrationManagerImplTest.java is an integration test based on
content shell test infra, we can't move it outside of //content.
So we consider to use other tests to replace it, while the renderer-side
testing has already been covered by layout tests created at
https://codereview.chromium.org/2731953003/, so we create this CL to
cover the VibrationManager interface impl testing:
 - creates an infra for Device Service service tests.
 - adds a new service test for VibrationManager interface.

Then after this CL we'll be able to hide all vibration impl inside
Device Service with a follow-up CL.

BUG=689379
TEST=service_unittests
TBR=avi@chromium.org

Review-Url: https://codereview.chromium.org/2774783003
Cr-Original-Commit-Position: refs/heads/master@{#463612}
Committed:
https://chromium.googlesource.com/chromium/src/+/9c17bee62f1e16224fabb7c83bbe...
Review-Url: https://codereview.chromium.org/2814013002
Cr-Commit-Position: refs/heads/master@{#463915}
Committed:
https://chromium.googlesource.com/chromium/src/+/70adfd46aefb86021a640567bdc0...
==========

[commit-bot: I haz the power, 2017-04-12 03:15:12]

Committed patchset #2 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/70adfd46aefb86021a640567bdc0...

[leonhsl(Using Gerrit), 2017-04-12 03:18:41]

On 2017/04/12 03:06:48, Ken Rockot wrote:
> (Done)
> 
> On Tue, Apr 11, 2017 at 8:06 PM, <mailto:rockot@chromium.org> wrote:
> 
> > On 2017/04/12 at 03:05:03, leon.han wrote:
> > > On 2017/04/12 03:02:12, leonhsl wrote:
> > > > Thanks Ken a lot! Let me TBR Avi for //content/ changes he approved in
> > original
> > > > CL, send to CQ now.
> > >
> > > Oops, seems I closed this CL incidentally... Will upload a new one to
> > land.
> >
> > We can just reopen it
> >
> > https://codereview.chromium.org/2814013002/
> >
> 
> -- 
> You received this message because you are subscribed to the Google Groups
> "Chromium-reviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

Ah, I see, did not know about this before.. It's in the 'Edit Issue' page. Thank
you :-)