Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(696)

Issue 2813963004: [Telemetry] Fix idle platform story so that it has a url. (Closed)

Created:
3 years, 8 months ago by rnephew (Reviews Here)
Modified:
3 years, 8 months ago
Reviewers:
nednguyen
CC:
chromium-reviews, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Telemetry] Fix idle platform story so that it has a url. It shouldn't require a url since it has no page, but a dependency requires it so this will make the benchmark work while I investigate how to remove that url dependency. https://github.com/catapult-project/catapult/issues/3489 BUG=700022 Review-Url: https://codereview.chromium.org/2813963004 Cr-Commit-Position: refs/heads/master@{#464111} Committed: https://chromium.googlesource.com/chromium/src/+/1dbbac2cfc9625af311200e67563ca6613f750b9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M tools/perf/page_sets/idle_platform.py View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
rnephew (Reviews Here)
3 years, 8 months ago (2017-04-12 15:19:48 UTC) #2
nednguyen
On 2017/04/12 15:19:48, rnephew (Reviews Here) wrote: lgtm
3 years, 8 months ago (2017-04-12 15:22:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2813963004/1
3 years, 8 months ago (2017-04-12 15:23:05 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-04-12 19:38:08 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1dbbac2cfc9625af311200e67563...

Powered by Google App Engine
This is Rietveld 408576698