Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Unified Diff: tools/perf/page_sets/idle_platform.py

Issue 2813963004: [Telemetry] Fix idle platform story so that it has a url. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/page_sets/idle_platform.py
diff --git a/tools/perf/page_sets/idle_platform.py b/tools/perf/page_sets/idle_platform.py
index b6fffd48a0cb0e930fca9f3439e9bf48202aa75c..b25af546ad7c677209cd9561a4cb25a19406ae09 100644
--- a/tools/perf/page_sets/idle_platform.py
+++ b/tools/perf/page_sets/idle_platform.py
@@ -28,10 +28,19 @@ class _IdleStory(story.Story):
super(_IdleStory, self).__init__(
shared_state_class=_IdleSharedState, name=name)
self._duration = duration
+ # https://github.com/catapult-project/catapult/issues/3489
+ # Even though there is no actual url being used, it is required for
+ # uploading results using the --upload-results flag. Remove url when
+ # it is no longer needed.
+ self._url = name
def Run(self, shared_state):
time.sleep(self._duration)
+ @property
+ def url(self):
+ return self._url
+
class IdleStorySet(story.StorySet):
def __init__(self):
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698