Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(664)

Issue 2813963002: //tools/binary_size: Consolidate most tools into "supersize" command (Closed)

Created:
3 years, 8 months ago by agrieve
Modified:
3 years, 8 months ago
Reviewers:
estevenson
CC:
chromium-reviews, wnwen+watch_chromium.org, estevenson+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

//tools/binary_size: Consolidate most tools into "supersize" command This should make clear which scripts relate to .size files. BUG=681694 Review-Url: https://codereview.chromium.org/2813963002 Cr-Commit-Position: refs/heads/master@{#463757} Committed: https://chromium.googlesource.com/chromium/src/+/5795cf77e5bcc458a5768831377a3c672b725136

Patch Set 1 #

Patch Set 2 : Fix readme formatting. Make archive's --outoput-file a positional arg #

Unified diffs Side-by-side diffs Delta from patch set Stats (+173 lines, -5407 lines) Patch
M tools/binary_size/OWNERS View 1 chunk +1 line, -2 lines 0 comments Download
M tools/binary_size/PRESUBMIT.py View 1 chunk +5 lines, -5 lines 0 comments Download
M tools/binary_size/README.md View 1 2 chunks +57 lines, -38 lines 0 comments Download
D tools/binary_size/console.py View 1 chunk +0 lines, -263 lines 0 comments Download
D tools/binary_size/create_html_breakdown.py View 1 chunk +0 lines, -205 lines 0 comments Download
D tools/binary_size/describe.py View 1 chunk +0 lines, -286 lines 0 comments Download
D tools/binary_size/file_format.py View 1 chunk +0 lines, -175 lines 0 comments Download
D tools/binary_size/function_signature.py View 1 chunk +0 lines, -104 lines 0 comments Download
D tools/binary_size/function_signature_test.py View 1 chunk +0 lines, -89 lines 0 comments Download
D tools/binary_size/helpers.py View 1 chunk +0 lines, -51 lines 0 comments Download
D tools/binary_size/integration_test.py View 1 chunk +0 lines, -156 lines 0 comments Download
A + tools/binary_size/libsupersize/archive.py View 1 3 chunks +15 lines, -17 lines 0 comments Download
A + tools/binary_size/libsupersize/console.py View 5 chunks +23 lines, -34 lines 0 comments Download
A + tools/binary_size/libsupersize/describe.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/binary_size/libsupersize/file_format.py View 1 chunk +2 lines, -1 line 0 comments Download
A + tools/binary_size/libsupersize/function_signature.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/binary_size/libsupersize/function_signature_test.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A tools/binary_size/libsupersize/helpers.py View 1 chunk +11 lines, -0 lines 0 comments Download
A + tools/binary_size/libsupersize/html_report.py View 5 chunks +11 lines, -12 lines 0 comments Download
A + tools/binary_size/libsupersize/integration_test.py View 1 4 chunks +12 lines, -14 lines 0 comments Download
A + tools/binary_size/libsupersize/linker_map_parser.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/binary_size/libsupersize/main.py View 4 chunks +45 lines, -13 lines 0 comments Download
A + tools/binary_size/libsupersize/match_util.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/binary_size/libsupersize/match_util_test.py View 1 chunk +1 line, -1 line 0 comments Download
A + tools/binary_size/libsupersize/models.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/binary_size/libsupersize/ninja_parser.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/binary_size/libsupersize/paths.py View 1 chunk +0 lines, -7 lines 0 comments Download
A + tools/binary_size/libsupersize/template/D3SymbolTreeMap.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/binary_size/libsupersize/template/index.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/binary_size/libsupersize/template/test-data-generator.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/binary_size/libsupersize/testdata/ActualDiff.golden View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/binary_size/libsupersize/testdata/Archive.golden View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/binary_size/libsupersize/testdata/ConsoleNullDiff.golden View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/binary_size/libsupersize/testdata/FullDescription.golden View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/binary_size/libsupersize/testdata/SymbolGroupMethods.golden View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/binary_size/libsupersize/testdata/build.ninja View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/binary_size/libsupersize/testdata/sub.ninja View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/binary_size/libsupersize/testdata/test.map View 0 chunks +-1 lines, --1 lines 0 comments Download
D tools/binary_size/linker_map_parser.py View 1 chunk +0 lines, -213 lines 0 comments Download
D tools/binary_size/map2size.py View 1 chunk +0 lines, -478 lines 0 comments Download
D tools/binary_size/match_util.py View 1 chunk +0 lines, -58 lines 0 comments Download
D tools/binary_size/match_util_test.py View 1 chunk +0 lines, -69 lines 0 comments Download
D tools/binary_size/models.py View 1 chunk +0 lines, -685 lines 0 comments Download
D tools/binary_size/ninja_parser.py View 1 chunk +0 lines, -89 lines 0 comments Download
D tools/binary_size/paths.py View 1 chunk +0 lines, -97 lines 0 comments Download
A tools/binary_size/supersize View 1 chunk +8 lines, -0 lines 0 comments Download
D tools/binary_size/template/D3SymbolTreeMap.js View 1 chunk +0 lines, -911 lines 0 comments Download
D tools/binary_size/template/index.html View 1 chunk +0 lines, -502 lines 0 comments Download
D tools/binary_size/template/test-data-generator.html View 1 chunk +0 lines, -157 lines 0 comments Download
D tools/binary_size/testdata/ActualDiff.golden View 1 chunk +0 lines, -183 lines 0 comments Download
D tools/binary_size/testdata/ConsoleNullDiff.golden View 1 chunk +0 lines, -20 lines 0 comments Download
D tools/binary_size/testdata/FullDescription.golden View 1 chunk +0 lines, -90 lines 0 comments Download
D tools/binary_size/testdata/Map2Size.golden View 1 chunk +0 lines, -46 lines 0 comments Download
D tools/binary_size/testdata/SymbolGroupMethods.golden View 1 chunk +0 lines, -85 lines 0 comments Download
D tools/binary_size/testdata/build.ninja View 1 chunk +0 lines, -8 lines 0 comments Download
D tools/binary_size/testdata/sub.ninja View 1 chunk +0 lines, -2 lines 0 comments Download
D tools/binary_size/testdata/test.map View 1 chunk +0 lines, -259 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 10 (5 generated)
agrieve
On 2017/04/11 20:07:19, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:estevenson@chromium.org
3 years, 8 months ago (2017-04-11 20:07:25 UTC) #3
estevenson
On 2017/04/11 20:07:25, agrieve wrote: > On 2017/04/11 20:07:19, agrieve wrote: > > mailto:agrieve@chromium.org changed ...
3 years, 8 months ago (2017-04-11 20:26:04 UTC) #4
estevenson
On 2017/04/11 20:07:25, agrieve wrote: > On 2017/04/11 20:07:19, agrieve wrote: > > mailto:agrieve@chromium.org changed ...
3 years, 8 months ago (2017-04-11 20:26:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2813963002/20001
3 years, 8 months ago (2017-04-11 20:28:51 UTC) #7
commit-bot: I haz the power
3 years, 8 months ago (2017-04-11 20:45:05 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/5795cf77e5bcc458a5768831377a...

Powered by Google App Engine
This is Rietveld 408576698