//tools/binary_size: Fix source paths for linux builds

//tools/binary_size: Fix source paths for linux builds

And update README.md example to mention LLVM_DOWNLOAD_GOLD_PLUGIN.

BUG=681694, 710461
Review-Url: https://codereview.chromium.org/2817553003
Cr-Commit-Position: refs/heads/master@{#464141}
Committed: https://chromium.googlesource.com/chromium/src/+/c666c641ced98002aeb38515fe44f722b3714201

[agrieve, 2017-04-12 14:05:17]

Description was changed from

==========
//tools/binary_size: Fix source paths for linux builds

And update README.md example to mention LLVM_DOWNLOAD_GOLD_PLUGIN.

BUG=681694,710461
==========

to

==========
//tools/binary_size: Fix source paths for linux builds

And update README.md example to mention LLVM_DOWNLOAD_GOLD_PLUGIN.

BUG=681694,710461
==========

[agrieve, 2017-04-12 14:05:17]

agrieve@chromium.org changed reviewers:
+ estevenson@chromium.org

[agrieve, 2017-04-12 14:06:12]

On 2017/04/12 14:05:17, agrieve wrote:
> mailto:agrieve@chromium.org changed reviewers:
> + mailto:estevenson@chromium.org

🚩

[Raphael Kubo da Costa (rakuco), 2017-04-12 14:20:12]

raphael.kubo.da.costa@intel.com changed reviewers:
+ raphael.kubo.da.costa@intel.com

[Raphael Kubo da Costa (rakuco), 2017-04-12 14:20:13]

Are the is_chrome_branded bits really necessary? IIUC they prevent any
non-Googler (myself included) from using those tools.

[agrieve, 2017-04-12 14:50:23]

On 2017/04/12 14:20:13, Raphael Kubo da Costa (rakuco) wrote:
> Are the is_chrome_branded bits really necessary? IIUC they prevent any
> non-Googler (myself included) from using those tools.

The perf bots have it turned on:
Linux:
https://luci-logdog.appspot.com/v/?s=chrome%2Fbb%2Fchromium.perf%2FLinux_Buil...
Android:
https://luci-logdog.appspot.com/v/?s=chrome%2Fbb%2Fchromium.perf%2FAndroid_Bu...

So I think that means it shouldn't break anything for you.

Having it enabled turns on more features that ship in Chrome. e.g.: 
proprietary_codecs = is_chrome_branded || is_chromecast
(https://cs.chromium.org/chromium/src/build/config/features.gni?type=cs&q=is_c...)

[Raphael Kubo da Costa (rakuco), 2017-04-12 15:04:18]

On 2017/04/12 14:50:23, agrieve wrote:
> On 2017/04/12 14:20:13, Raphael Kubo da Costa (rakuco) wrote:
> > Are the is_chrome_branded bits really necessary? IIUC they prevent any
> > non-Googler (myself included) from using those tools.
> 
> The perf bots have it turned on:
> Linux:
>
https://luci-logdog.appspot.com/v/?s=chrome%2Fbb%2Fchromium.perf%2FLinux_Buil...
> Android:
>
https://luci-logdog.appspot.com/v/?s=chrome%2Fbb%2Fchromium.perf%2FAndroid_Bu...

The bots likely have access to internal resources as well. I can't even see
those pages as I get a "Not authenticated. Please log in." error message.

> So I think that means it shouldn't break anything for you.

A fresh Android build with is_chrome_branded=true fails here with:

  ninja: error:
'../../chrome/browser/internal/transform_additional_modules_list.py', needed by
'obj/chrome/browser/chrome_internal_resources_gen.inputdeps.stamp', missing and
no known rule to make it

|is_chrome_branded|'s documentation in build/config/chrome_build.gni also says
"requires extra Google-internal resources".

[estevenson, 2017-04-12 17:49:44]

Tested locally with a fresh Linux checkout and it worked for me!

lgtm

[agrieve, 2017-04-12 20:13:45]

The CQ bit was checked by agrieve@chromium.org

[agrieve, 2017-04-12 20:13:45]

The patchset sent to the CQ was uploaded after l-g-t-m from
estevenson@chromium.org
Link to the patchset: https://codereview.chromium.org/2817553003/#ps60001
(title: "add exclude_unwind_tables")

[commit-bot: I haz the power, 2017-04-12 20:15:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 20:44:42]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1492028025497740,
"parent_rev": "58d40e4d8570ce25575e42709c6b534124a99612", "commit_rev":
"c666c641ced98002aeb38515fe44f722b3714201"}

[commit-bot: I haz the power, 2017-04-12 20:45:39]

Description was changed from

==========
//tools/binary_size: Fix source paths for linux builds

And update README.md example to mention LLVM_DOWNLOAD_GOLD_PLUGIN.

BUG=681694,710461
==========

to

==========
//tools/binary_size: Fix source paths for linux builds

And update README.md example to mention LLVM_DOWNLOAD_GOLD_PLUGIN.

BUG=681694,710461

Review-Url: https://codereview.chromium.org/2817553003
Cr-Commit-Position: refs/heads/master@{#464141}
Committed:
https://chromium.googlesource.com/chromium/src/+/c666c641ced98002aeb38515fe44...
==========

[commit-bot: I haz the power, 2017-04-12 20:45:42]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/c666c641ced98002aeb38515fe44...