Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2813903007: Hide USB service unavailability from web content (Closed)

Created:
3 years, 8 months ago by Reilly Grant (use Gerrit)
Modified:
3 years, 8 months ago
CC:
blink-reviews, chromium-reviews, haraken
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Hide USB service unavailability from web content This changes the handling of Mojo service connection errors so that they are treated as if the service were present but returned no devices instead of surfacing a specific failure message for this case. This simplifies content_shell-based tests for WebUSB. BUG=711443 Review-Url: https://codereview.chromium.org/2813903007 Cr-Commit-Position: refs/heads/master@{#464811} Committed: https://chromium.googlesource.com/chromium/src/+/f809e180a16f5b87c3eb36101ffa342dc4e9bf0c

Patch Set 1 #

Patch Set 2 : Keep "No device selected." error text #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -10 lines) Patch
M third_party/WebKit/Source/modules/webusb/USB.cpp View 1 3 chunks +5 lines, -10 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
Reilly Grant (use Gerrit)
This is the change we discussed. PTAL.
3 years, 8 months ago (2017-04-13 21:25:37 UTC) #2
Ken Rockot(use gerrit already)
lgtm
3 years, 8 months ago (2017-04-13 21:28:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2813903007/1
3 years, 8 months ago (2017-04-13 21:32:00 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/405104)
3 years, 8 months ago (2017-04-13 22:36:23 UTC) #7
Reilly Grant (use Gerrit)
Keep "No device selected." error text
3 years, 8 months ago (2017-04-14 20:52:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2813903007/20001
3 years, 8 months ago (2017-04-14 20:53:59 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-04-14 22:32:40 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f809e180a16f5b87c3eb36101ffa...

Powered by Google App Engine
This is Rietveld 408576698