Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(581)

Unified Diff: third_party/WebKit/Source/modules/webusb/USB.cpp

Issue 2813903007: Hide USB service unavailability from web content (Closed)
Patch Set: Keep "No device selected." error text Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/modules/webusb/USB.cpp
diff --git a/third_party/WebKit/Source/modules/webusb/USB.cpp b/third_party/WebKit/Source/modules/webusb/USB.cpp
index 236a627181d4589dff98cc559aa54205753a3f6a..cbe3e04d5d757b0481760d404933cbd48045166c 100644
--- a/third_party/WebKit/Source/modules/webusb/USB.cpp
+++ b/third_party/WebKit/Source/modules/webusb/USB.cpp
@@ -26,7 +26,7 @@ namespace usb = device::usb::blink;
namespace blink {
namespace {
-const char kNoServiceError[] = "USB service unavailable.";
+const char kNoDeviceSelected[] = "No device selected.";
usb::DeviceFilterPtr ConvertDeviceFilter(const USBDeviceFilter& filter) {
auto mojo_filter = usb::DeviceFilter::New();
@@ -172,16 +172,11 @@ void USB::OnGetPermission(ScriptPromiseResolver* resolver,
chooser_service_requests_.erase(request_entry);
EnsureDeviceManagerConnection();
- if (!device_manager_) {
- resolver->Reject(DOMException::Create(kNotFoundError, kNoServiceError));
- return;
- }
- if (device_info) {
+ if (device_manager_ && device_info) {
resolver->Resolve(GetOrCreateDevice(std::move(device_info)));
} else {
- resolver->Reject(
- DOMException::Create(kNotFoundError, "No device selected."));
+ resolver->Reject(DOMException::Create(kNotFoundError, kNoDeviceSelected));
}
}
@@ -208,14 +203,14 @@ void USB::OnDeviceManagerConnectionError() {
device_manager_.reset();
client_binding_.Close();
for (ScriptPromiseResolver* resolver : device_manager_requests_)
- resolver->Reject(DOMException::Create(kNotFoundError, kNoServiceError));
+ resolver->Resolve(HeapVector<Member<USBDevice>>(0));
device_manager_requests_.Clear();
}
void USB::OnChooserServiceConnectionError() {
chooser_service_.reset();
for (ScriptPromiseResolver* resolver : chooser_service_requests_)
- resolver->Reject(DOMException::Create(kNotFoundError, kNoServiceError));
+ resolver->Reject(DOMException::Create(kNotFoundError, kNoDeviceSelected));
chooser_service_requests_.Clear();
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698