[Windows MSVC CFG] Link with CFG only on executables.

[Windows MSVC CFG]  Link with CFG only on executables.

Adjust GN configs to only link with Control Flow Guard for executables.
This will still support CFG compiled into Microsoft system DLLs, in all
Chromium processes (e.g. chrome.exe).

This should prevent sporadic official clang build problems in DLLs, related
to CFG.  Further investigation/fixes to follow.

TEST=CFGSupportTests.MsIndirectFailure in sbox_integration_tests suite.
BUG=584575, 708098
Review-Url: https://codereview.chromium.org/2813823006
Cr-Commit-Position: refs/heads/master@{#464475}
Committed: https://chromium.googlesource.com/chromium/src/+/723503ec2956cc8b66e53a5ee97985ec262a599d

[penny, 2017-04-13 05:19:37]

Description was changed from

==========
[Windows MSVC CFG]  Link with CFG only on executables.

Adjust GN configs to only link with Control Flow Guard for executables.
This will still support CFG compiled into Microsoft system DLLs, in all
Chromium processes (e.g. chrome.exe).

This should prevent sporadic official clang build problems in DLLs, related
to CFG.  Further investigation/fixes to follow.

TEST=CFGSupportTests.MsIndirectFailure in sbox_integration_tests suite.
BUG=584575,708098
==========

to

==========
[Windows MSVC CFG]  Link with CFG only on executables.

Adjust GN configs to only link with Control Flow Guard for executables.
This will still support CFG compiled into Microsoft system DLLs, in all
Chromium processes (e.g. chrome.exe).

This should prevent sporadic official clang build problems in DLLs, related
to CFG.  Further investigation/fixes to follow.

TEST=CFGSupportTests.MsIndirectFailure in sbox_integration_tests suite.
BUG=584575,708098
==========

[penny, 2017-04-13 05:19:37]

pennymac@chromium.org changed reviewers:
+ scottmg@chromium.org

[penny, 2017-04-13 05:21:04]

Hi Scott,

Immediate fix for occasional corrupt DLLs during official clang builds.

PTAL!  Thanks. :)

[penny, 2017-04-13 05:42:39]

The CQ bit was checked by pennymac@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-13 05:42:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[scottmg, 2017-04-13 06:01:19]

Seems fine as a fix since it was affecting chrome_child.dll, but do we have
reasonable confidence that this isn't going to pop up on chrome.exe in the
future? If so, could you add some more explanation to the bug?

lgtm

https://codereview.chromium.org/2813823006/diff/1/build/config/BUILD.gn
File build/config/BUILD.gn (right):

https://codereview.chromium.org/2813823006/diff/1/build/config/BUILD.gn#newco...
build/config/BUILD.gn:286: # Currently only turn on linker CFI for executables.
Can you add a link here to the bug?

[commit-bot: I haz the power, 2017-04-13 07:01:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-13 07:01:05]

Dry run: This issue passed the CQ dry run.

[penny, 2017-04-13 18:14:28]

The CQ bit was checked by pennymac@chromium.org

[commit-bot: I haz the power, 2017-04-13 18:14:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 18:23:15]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1492107268140590, "parent_rev":
"66e4895ec848860ed812821d2fd48b5caf23981a", "commit_rev":
"723503ec2956cc8b66e53a5ee97985ec262a599d"}

[commit-bot: I haz the power, 2017-04-13 18:24:24]

Description was changed from

==========
[Windows MSVC CFG]  Link with CFG only on executables.

Adjust GN configs to only link with Control Flow Guard for executables.
This will still support CFG compiled into Microsoft system DLLs, in all
Chromium processes (e.g. chrome.exe).

This should prevent sporadic official clang build problems in DLLs, related
to CFG.  Further investigation/fixes to follow.

TEST=CFGSupportTests.MsIndirectFailure in sbox_integration_tests suite.
BUG=584575,708098
==========

to

==========
[Windows MSVC CFG]  Link with CFG only on executables.

Adjust GN configs to only link with Control Flow Guard for executables.
This will still support CFG compiled into Microsoft system DLLs, in all
Chromium processes (e.g. chrome.exe).

This should prevent sporadic official clang build problems in DLLs, related
to CFG.  Further investigation/fixes to follow.

TEST=CFGSupportTests.MsIndirectFailure in sbox_integration_tests suite.
BUG=584575,708098

Review-Url: https://codereview.chromium.org/2813823006
Cr-Commit-Position: refs/heads/master@{#464475}
Committed:
https://chromium.googlesource.com/chromium/src/+/723503ec2956cc8b66e53a5ee979...
==========

[commit-bot: I haz the power, 2017-04-13 18:24:27]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/723503ec2956cc8b66e53a5ee979...