Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Side by Side Diff: build/config/BUILD.gn

Issue 2813823006: [Windows MSVC CFG] Link with CFG only on executables. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | build/config/win/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/allocator.gni") 5 import("//build/config/allocator.gni")
6 import("//build/config/chrome_build.gni") 6 import("//build/config/chrome_build.gni")
7 import("//build/config/chromecast_build.gni") 7 import("//build/config/chromecast_build.gni")
8 import("//build/config/crypto.gni") 8 import("//build/config/crypto.gni")
9 import("//build/config/dcheck_always_on.gni") 9 import("//build/config/dcheck_always_on.gni")
10 import("//build/config/features.gni") 10 import("//build/config/features.gni")
(...skipping 264 matching lines...) Expand 10 before | Expand all | Expand 10 after
275 "//build/config/win:common_linker_setup", 275 "//build/config/win:common_linker_setup",
276 ] 276 ]
277 } 277 }
278 278
279 # This config defines the configs applied to all executables. 279 # This config defines the configs applied to all executables.
280 config("executable_config") { 280 config("executable_config") {
281 configs = [] 281 configs = []
282 282
283 if (is_win) { 283 if (is_win) {
284 configs += _windows_linker_configs 284 configs += _windows_linker_configs
285
286 # Currently only turn on linker CFI for executables.
scottmg 2017/04/13 06:01:18 Can you add a link here to the bug?
287 configs += [ "//build/config/win:cfi_linker" ]
285 } else if (is_mac) { 288 } else if (is_mac) {
286 configs += [ 289 configs += [
287 "//build/config/mac:mac_dynamic_flags", 290 "//build/config/mac:mac_dynamic_flags",
288 "//build/config/mac:mac_executable_flags", 291 "//build/config/mac:mac_executable_flags",
289 ] 292 ]
290 } else if (is_ios) { 293 } else if (is_ios) {
291 configs += [ "//build/config/ios:ios_dynamic_flags" ] 294 configs += [ "//build/config/ios:ios_dynamic_flags" ]
292 } else if (is_linux || is_android) { 295 } else if (is_linux || is_android) {
293 configs += [ "//build/config/gcc:executable_ldconfig" ] 296 configs += [ "//build/config/gcc:executable_ldconfig" ]
294 if (is_android) { 297 if (is_android) {
(...skipping 76 matching lines...) Expand 10 before | Expand all | Expand 10 after
371 # then delete the precompile.c.obj file, then build again. 374 # then delete the precompile.c.obj file, then build again.
372 # 375 #
373 # TODO(sof): determine VS2015 status and retire the setting from all 376 # TODO(sof): determine VS2015 status and retire the setting from all
374 # precompiled configurations. 377 # precompiled configurations.
375 cflags_c = [ "/wd4206" ] 378 cflags_c = [ "/wd4206" ]
376 } else if (is_mac) { 379 } else if (is_mac) {
377 precompiled_source = "//build/precompile.h" 380 precompiled_source = "//build/precompile.h"
378 } 381 }
379 } 382 }
380 } 383 }
OLDNEW
« no previous file with comments | « no previous file | build/config/win/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698