Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Issue 2813723002: Workaround for NotificationManager race condition (Closed)

Created:
3 years, 8 months ago by David Trainor- moved to gerrit
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Workaround for NotificationManager race condition It looks like we occasionally handle the notification click intent while the notification is still temporarily there. This check adds the notification id of the dying notification to the intent, so we can ignore it when scanning the existing notifications to see if any still require us to have our summary notification active. BUG=709560 Review-Url: https://codereview.chromium.org/2805843002 Cr-Commit-Position: refs/heads/master@{#463120} (cherry picked from commit ce4c38c5b3535bcb4a08cf2771db378aa8f278f9) Review-Url: https://codereview.chromium.org/2813723002 . Cr-Commit-Position: refs/branch-heads/3029@{#649} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/e7b3984a7e4bf958d24085c50967156174a35329

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -6 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/download/DownloadBroadcastReceiver.java View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java View 3 chunks +12 lines, -4 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationConstants.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
David Trainor- moved to gerrit
3 years, 8 months ago (2017-04-10 18:38:42 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e7b3984a7e4bf958d24085c50967156174a35329.

Powered by Google App Engine
This is Rietveld 408576698